Uh oh!
There was an error while loading. Please reload this page.
Updated E0433 to new error message. (no bonus) - #35536
Conversation
rust-highfive
commented
Aug 8, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sophiajt
commented
Aug 8, 2016
Thanks for the PR! Be sure to update the corresponding unit test. I talk about some ways you can do this in the blog post |
hank-der-hafenarbeiter
commented
Aug 9, 2016
Unit testing checks out for me though. There is no "compile-fail/E0433.rs" and "compile-fail/derived-errors/issue-31997-1.rs" gives an ok on my end. |
sophiajt
commented
Aug 9, 2016
@hank-der-hafenarbeiter - There's a quirk in the tester that won't check the labels if there isn't at least one NOTE in the unit test. I talk about this quirk in the Extra Credit section of the blog post. You can update the test file you have with at least one NOTE to test the label you added. |
hank-der-hafenarbeiter
commented
Aug 9, 2016
Oh didn't see that! I'll check tomorrow. it's past 2 am around here gotta get some sleep first. |
sophiajt
commented
Aug 9, 2016
Looks good! @bors r+ rollup |
bors
commented
Aug 9, 2016
📌 Commit b5ead00 has been approved by |
…athandturner Updated E0433 to new error message. (no bonus) Part of rust-lang#35345 r? @jonathandturner
…athandturner Updated E0433 to new error message. (no bonus) Part of rust-lang#35345 r? @jonathandturner
…athandturner Updated E0433 to new error message. (no bonus) Part of rust-lang#35345 r? @jonathandturner
Part of #35345
r? @jonathandturner