Update E0207 to use struct_span_err, add span_label

[shantanuraj]

Fixes#35302 part of #35233

r? @jonathandturner

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[sophiajt]

Thanks for the PR!

You'll also need to update the corresponding unit tests. You can find them by running git grep E0207

jturner-23759:rust jturner$ git grep E0207
...
src/test/compile-fail/E0207.rs:impl<T: Default> Foo { //~ ERROR E0207
src/test/compile-fail/impl-unused-rps-in-assoc-type.rs:impl<'a> Fun for Holder { //~ ERROR E0207
src/test/compile-fail/issue-22886.rs:impl<'a> Iterator for Newtype { //~ ERROR E0207
src/test/compile-fail/issue-35139.rs:impl<'a> MethodType for MTFn { //~ ERROR E0207

[sophiajt]

Looks good!

@bors r+ rollup

[bors]

📌 Commit 58b618e has been approved by jonathandturner

[shantanuraj]

Awesome, thanks for the insight @jonathandturner the unit tests seemed a little challenging at first, then I looked into another commit GuillaumeGomez@158597f which gave some insight about adding them.