Update E0206 message to new format by KiChjang · Pull Request #35402 · rust-lang/rust

KiChjang · 2016-08-05T23:15:40Z

Part of #35233.
Fixes#35301.

r? @GuillaumeGomez

GuillaumeGomez · 2016-08-06T11:11:41Z

Great work, thanks!

@bors: r+ rollup

bors · 2016-08-06T11:11:42Z

📌 Commit 5bab0e6 has been approved by GuillaumeGomez

@GuillaumeGomez

…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

Rollup of 9 pull requests - Successful merges: #35362, #35393, #35394, #35402, #35410, #35411, #35413, #35419, #35421 - Failed merges: #35395, #35415

@GuillaumeGomez

…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

@GuillaumeGomez

…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

TimNN · 2016-08-07T16:28:15Z

From a local build of the rollup #35462 which included this PR, I believe that this PR causes the compile-fail tests E0206.rs and coherence-impls-copy.rs to fail due to missing notes, see #35462 (comment) for the full test output (I would guess that travis passed since the source branch is some commits behind rust-lang/rust/master).

sophiajt · 2016-08-07T16:38:49Z

@TimNN - it may be the combination of PRs that are causing the failures, since TravisCI passed this one by itself.

Looking into it...

TimNN · 2016-08-07T16:40:23Z

@jonathandturner

I would guess that travis passed since the source branch is some commits (edit: 100+) behind rust-lang/rust/master

sophiajt · 2016-08-07T16:45:34Z

@bors r-

Ah, I missed that.

sophiajt · 2016-08-07T16:58:13Z

@KiChjang - can you make sure your PR is rebased against the latest master? This failure may be coming from something that was added after you first submitted your PR.

KiChjang · 2016-08-07T20:59:27Z

I've rebased, but I didn't run into any merge conflicts. python src/bootstrap/bootstrap.py --step check-cfail --stage 1 also didn't return any errors.

GuillaumeGomez · 2016-08-07T21:04:22Z

Let's give it a retry then (didn't see the problem the first time but whatever).

@bors: r+ rollup

bors · 2016-08-07T21:04:23Z

📌 Commit 413c321 has been approved by GuillaumeGomez

KiChjang · 2016-08-07T21:13:08Z

Wait, I see the problem. #35454 didn't update coherence-impls-copy.rs nor E0206.rs, so there's an extra note that wasn't expected.

@GuillaumeGomez

…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

GuillaumeGomez · 2016-08-07T21:31:54Z

@bors: r-

Rollup of 6 pull requests - Successful merges: #35396, #35402, #35446, #35466, #35470, #35475 - Failed merges: #35395, #35415

GuillaumeGomez · 2016-08-07T22:36:50Z

@bors: r+ rollup

bors · 2016-08-07T22:36:51Z

📌 Commit 53baa09 has been approved by GuillaumeGomez

bors · 2016-08-08T00:31:55Z

⌛ Testing commit 53baa09 with merge 6153bbb...

@GuillaumeGomez

Update E0206 message to new format Part of #35233. Fixes#35301. r? @GuillaumeGomez

bors · 2016-08-08T05:05:01Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing 6153bbb to master...

rust-highfive assigned GuillaumeGomez Aug 5, 2016

KiChjang force-pushed the e0206-new-msg branch 2 times, most recently from 91726cf to 5bab0e6Compare August 6, 2016 04:10

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 6, 2016
Rollup merge ofrust-lang#35402- KiChjang:e0206-new-msg, r=Guillaume…
ae59b96
…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 6, 2016
Rollup of 9 pull requests #35430
Closed

bors added a commit that referenced this pull request Aug 6, 2016
Auto merge of#35430- jonathandturner:rollup, r=jonathandturner
f0d7e4e
Rollup of 9 pull requests - Successful merges: #35362, #35393, #35394, #35402, #35410, #35411, #35413, #35419, #35421 - Failed merges: #35395, #35415

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge ofrust-lang#35402- KiChjang:e0206-new-msg, r=Guillaume…
c67a142
…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 7, 2016
Rollup of 14 pull requests #35441
Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge ofrust-lang#35402- KiChjang:e0206-new-msg, r=Guillaume…
d58d045
…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 7, 2016
Rollup of 19 pull requests #35462
Closed

KiChjang force-pushed the e0206-new-msg branch from 5bab0e6 to 413c321Compare August 7, 2016 20:58

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge ofrust-lang#35402- KiChjang:e0206-new-msg, r=Guillaume…
ce81500
…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixesrust-lang#35301. r? @GuillaumeGomez

sophiajt mentioned this pull request Aug 7, 2016
Rollup of 6 pull requests #35476
Closed

bors added a commit that referenced this pull request Aug 7, 2016
Auto merge of#35476- jonathandturner:rollup, r=jonathandturner
8913330
Rollup of 6 pull requests - Successful merges: #35396, #35402, #35446, #35466, #35470, #35475 - Failed merges: #35395, #35415

Update E0206 message to new format
53baa09

KiChjang force-pushed the e0206-new-msg branch from 413c321 to 53baa09Compare August 7, 2016 22:35

bors added a commit that referenced this pull request Aug 8, 2016
Auto merge of#35402- KiChjang:e0206-new-msg, r=GuillaumeGomez
6153bbb
Update E0206 message to new format Part of #35233. Fixes#35301. r? @GuillaumeGomez

bors merged commit 53baa09 into rust-lang:masterAug 8, 2016

KiChjang deleted the e0206-new-msg branch August 8, 2016 05:14

Uh oh!

Uh oh!

Conversation

KiChjang commented Aug 5, 2016

Uh oh!

GuillaumeGomez commented Aug 6, 2016

Uh oh!

bors commented Aug 6, 2016

Uh oh!

TimNN commented Aug 7, 2016

Uh oh!

sophiajt commented Aug 7, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TimNN commented Aug 7, 2016

Uh oh!

sophiajt commented Aug 7, 2016

Uh oh!

sophiajt commented Aug 7, 2016

Uh oh!

KiChjang commented Aug 7, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Aug 7, 2016

Uh oh!

bors commented Aug 7, 2016

Uh oh!

KiChjang commented Aug 7, 2016

Uh oh!

GuillaumeGomez commented Aug 7, 2016

Uh oh!

GuillaumeGomez commented Aug 7, 2016

Uh oh!

bors commented Aug 7, 2016

Uh oh!

bors commented Aug 8, 2016

Uh oh!

bors commented Aug 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sophiajt commented Aug 7, 2016•
edited
Loading

KiChjang commented Aug 7, 2016•
edited
Loading