Skip to content

Update E0214 to the new error format - #35470

Merged
bors merged 1 commit into
rust-lang:masterfrom
munyari:e0214
Aug 10, 2016
Merged

Update E0214 to the new error format#35470
bors merged 1 commit into
rust-lang:masterfrom
munyari:e0214

Conversation

@munyari

@munyarimunyari commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Part of #35233

Addresses #35383
"r? @jonathandturner

@rust-highfive

rust-highfive commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Looks good!

@bors r+ rollup

@bors

bors commented Aug 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit f07f093 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35470- munyari:e0214, r=jonathandturner
625a010
Update E0214 to the new error format
Part of rust-lang#35233
Addresses rust-lang#35383
"r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Closed
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of#35476- jonathandturner:rollup, r=jonathandturner
8913330
Rollup of 6 pull requests
- Successful merges: #35396, #35402, #35446, #35466, #35470, #35475
- Failed merges: #35395, #35415
@bors

bors commented Aug 8, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f07f093 with merge 613cdcc...

@bors

bors commented Aug 8, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton

alexcrichton commented Aug 8, 2016

Copy link
Copy Markdown
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
Jonathan Turner
Rollup merge ofrust-lang#35470- munyari:e0214, r=jonathandturner
0e4e8e9
Update E0214 to the new error format
Part of rust-lang#35233
Addresses rust-lang#35383
"r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 8, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge ofrust-lang#35470- munyari:e0214, r=jonathandturner
9c1e4cb
Update E0214 to the new error format
Part of rust-lang#35233
Addresses rust-lang#35383
"r? @jonathandturner
@steveklabniksteveklabnik mentioned this pull request Aug 10, 2016
Closed
bors added a commit that referenced this pull request Aug 10, 2016
@bors
Auto merge of#35525- jonathandturner:rollup, r=jonathandturner
1f2ae38
Rollup of 15 pull requests
- Successful merges: #35371, #35396, #35446, #35449, #35452, #35458, #35465, #35466, #35470, #35475, #35477, #35484, #35504, #35507, #35524
- Failed merges: #35395, #35415
@bors
bors merged commit f07f093 into rust-lang:masterAug 10, 2016
@munyari
munyari deleted the e0214 branch August 11, 2016 01:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@munyari@rust-highfive@sophiajt@bors@alexcrichton