Skip to content

book: fix formatting of module layout example - #35466

Merged
bors merged 1 commit into
rust-lang:masterfrom
xitep:master
Aug 10, 2016
Merged

book: fix formatting of module layout example#35466
bors merged 1 commit into
rust-lang:masterfrom
xitep:master

Conversation

@xitep

@xitepxitep commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@xitep

xitep commented Aug 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Just noticed that the "creates and module" layout graph is broken for nightlies; hopefully this fixes the issue.

@steveklabnik

steveklabnik commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thanks!

@bors

bors commented Aug 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 98c6770 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35466- xitep:master, r=steveklabnik
3fdd637
book: fix formatting of module layout example
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Closed
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of#35476- jonathandturner:rollup, r=jonathandturner
8913330
Rollup of 6 pull requests
- Successful merges: #35396, #35402, #35446, #35466, #35470, #35475
- Failed merges: #35395, #35415
@bors

bors commented Aug 8, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 98c6770 with merge 42f92b8...

@bors

bors commented Aug 8, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-64-opt

@steveklabnik

steveklabnik commented Aug 8, 2016

Copy link
Copy Markdown
Contributor

@bors: retry

seems spurious

@alexcrichton

alexcrichton commented Aug 8, 2016

Copy link
Copy Markdown
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
Jonathan Turner
Rollup merge ofrust-lang#35466- xitep:master, r=steveklabnik
3d2d5c4
book: fix formatting of module layout example
@sophiajtsophiajt mentioned this pull request Aug 8, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge ofrust-lang#35466- xitep:master, r=steveklabnik
7377583
book: fix formatting of module layout example
@steveklabniksteveklabnik mentioned this pull request Aug 10, 2016
Closed
bors added a commit that referenced this pull request Aug 10, 2016
@bors
Auto merge of#35525- jonathandturner:rollup, r=jonathandturner
1f2ae38
Rollup of 15 pull requests
- Successful merges: #35371, #35396, #35446, #35449, #35452, #35458, #35465, #35466, #35470, #35475, #35477, #35484, #35504, #35507, #35524
- Failed merges: #35395, #35415
@bors
bors merged commit 98c6770 into rust-lang:masterAug 10, 2016
@durkadurka mentioned this pull request Aug 23, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ManishearthManishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xitep@rust-highfive@steveklabnik@bors@alexcrichton@Manishearth