Uh oh!
There was an error while loading. Please reload this page.
Conversation
rust-highfive
commented
Aug 7, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sophiajt
commented
Aug 7, 2016
Thanks for the PR! Can you also update the corresponding unit test(s) to test for the new label? You may need to add a couple tests so that you can test for the variations. |
I added a note to src/test/compile-fail/E0087.rs to match the new error format |
sophiajt
commented
Aug 7, 2016
Great! One last thing, since it's pretty small, can you squash your 2 commits into 1? After that, I think it'll be ready. |
ghost
commented
Aug 7, 2016
Sure Jonathan :) |
sophiajt
commented
Aug 7, 2016
Thanks! @bors r+ rollup |
bors
commented
Aug 7, 2016
📌 Commit 8b111a7 has been approved by |
bors
commented
Aug 8, 2016
⌛ Testing commit 8b111a7 with merge adaf9f9... |
bors
commented
Aug 8, 2016
💔 Test failed - auto-win-gnu-64-opt |
alexcrichton
commented
Aug 8, 2016
@bors: retry
|
Updated E0087 to new format Part of rust-lang#35233. r? @jonathandturner
ghost
commented
Aug 9, 2016
It is my fault? D: |
sophiajt
commented
Aug 9, 2016
@poveda-ruiz - there was an extra space at the end of one of your lines. I've merged this PR in with a bunch of other PRs, so I'm just going to fix it on my end. For your next one, you can run: |
Damn, sorry :( yeah aparently I forgot to run it after correcting the unit test |
Updated E0087 to new format Part of rust-lang#35233. r? @jonathandturner
Part of #35233. r? @jonathandturner