Uh oh!
There was an error while loading. Please reload this page.
Rollup of 15 pull requests - #35525
Merged
Merged
Conversation
sophiajt
commented
Aug 8, 2016
Contributor
- Successful merges: Update HashMap docs regarding DoS protection #35371, Update E0191 to the new error format #35396, Update E0023 to the new format #35446, Updated E0087 to new format #35449, Finish fixing the operator precedence tables #35452, Add run-pass test for issue 33498 #35458, book: update example patterns to be more clear #35465, book: fix formatting of module layout example #35466, Update E0214 to the new error format #35470, E0248, E0267 & E0268 New Format #35475, Fix E0132 error display #35477, Shrink E0205 span label to the trait being implemented #35484, Updated E0026 to new format. #35504, Updated Error mesage to new format for E0221 #35507, Update E0162 to the new format #35524
- Failed merges: Update E0057 error message to new format #35395, Update compiler error 0030 to use new error format. #35415
Because of changes to how Rust acquires randomness HashMap is not guaranteed to be DoS resistant. This commit reflects these changes in the docs themselves and provides an alternative method to creating a hash that is resistant if needed.
Added some extra code to check for the appropriate ending for numbers == 1 vs. not 1 in error messages. Added an extra test so that the plural suffix is seen and exercised.
Add the unstable `:` colon and `<-` inplace operators.
When using Point { x: 0, y: 0 } and showing pattern matching decomposing
x and y individually its hard to understand. By using a different value
for x and a different value for y it is more clear.Update HashMap docs regarding DoS protection Because of changes to how Rust acquires randomness HashMap is not guaranteed to be DoS resistant. This commit reflects these changes in the docs themselves and provides an alternative method to creating a hash that is resistant if needed. This fixesrust-lang#33817 and includes relevant information regarding changes made in rust-lang#33086
Update E0191 to the new error format Part of rust-lang#35233 "r? @jonathandturner
…onathandturner Update E0023 to the new format Added some extra code to check for the appropriate ending for numbers == 1 vs. not 1 in error messages. Added an extra test so that the plural suffix is seen and exercised.
Updated E0087 to new format Part of rust-lang#35233. r? @jonathandturner
Finish fixing the operator precedence tables Add the unstable `:` colon and `<-` inplace operators. r? @steveklabnik
…lexcrichton Add run-pass test for issue 33498 Fixesrust-lang#33498. r? @alexcrichton
…klabnik
book: update example patterns to be more clear
When using Point { x: 0, y: 0 } and showing pattern matching decomposing
x and y individually its hard to understand. By using a different value
for x and a different value for y it is more clear.book: fix formatting of module layout example
Update E0214 to the new error format Part of rust-lang#35233 Addresses rust-lang#35383 "r? @jonathandturner
…urner E0248 New Format
…ndturner Fix E0132 error display Error and note now use the same span. r? @jonathandturner
Shrink E0205 span label to the trait being implemented Part of rust-lang#35233. Extension of rust-lang#35468. Closesrust-lang#35382. r? @GuillaumeGomez
…t, r=jonathandturner Updated E0026 to new format. Part of rust-lang#35233. Fixesrust-lang#35497. r? @jonathandturner
added 2 commits
August 8, 2016 13:25
…nathandturner Updated Error mesage to new format for E0221 Part of rust-lang#35386 r? @jonathandturner
…ormat, r=jonathandturner Update E0162 to the new format Part of rust-lang#35233. Fixesrust-lang#35268. r? @jonathandturner
rust-highfive
commented
Aug 8, 2016
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
sophiajt
commented
Aug 8, 2016
ContributorAuthor
@bors r+ |
bors
commented
Aug 8, 2016
Collaborator
📌 Commit f835b38 has been approved by |
sanxiyn
commented
Aug 9, 2016
Contributor
#35449 failed tidy. |
sophiajt
commented
Aug 9, 2016
ContributorAuthor
Fixed tidy warning @bors r+ |
bors
commented
Aug 9, 2016
Collaborator
📌 Commit fb1c6ac has been approved by |
steveklabnik
commented
Aug 10, 2016
Contributor
@bors: p=1 |
bors
commented
Aug 10, 2016
Collaborator
bors added a commit
that referenced
this pull request
Aug 10, 2016
bors
commented
Aug 10, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.