Uh oh!
There was an error while loading. Please reload this page.
Add testcase for issue-32948 - #36832
Conversation
rust-highfive
commented
Sep 29, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
nikomatsakis
commented
Oct 4, 2016
michaelwoerister
commented
Oct 5, 2016
Thanks a lot, @ParkHanbum! # The following command will:# 1. dump the symbols of a library using `nm`# 2. extract only those lines that we are interested in via `grep`# 3. from those lines, extract just the symbol name via `sed`# (symbol names always start with "_ZN" and end with "E")# 4. sort those symbol names for deterministic comparison# 5. write the result into a filedump-symbols = nm "$(TMPDIR)/lib$(1).rlib" \
| grep -E "some_test_function|Bar|bar" \
| sed "s/.*\(_ZN.*E\).*/\1/" \
| sort \
> "$(TMPDIR)/$(1).nm"That would make it easier for future maintainers. If you do that, I'd be happy to approve the PR. |
ParkHanbum
commented
Oct 6, 2016
@michaelwoerister cosider it done!! I'll be better then this PR next. thanks a lot !! |
michaelwoerister
commented
Oct 6, 2016
@bors r+ |
bors
commented
Oct 6, 2016
📌 Commit cb700e7 has been approved by |
michaelwoerister
commented
Oct 6, 2016
Thanks a lot, @ParkHanbum! My comment wasn't meant as criticism. |
michaelwoerister
commented
Oct 6, 2016
@bors p=rollup Let's see if that works... |
michaelwoerister
commented
Oct 6, 2016
@bors rollup |
Add testcase for issue-32948 issue-32948 is similar to issue-32554. issue-32948 : Symbol names for monomorphized trait impls are not stable across crates issue-32554 : Symbol names for generics are not stable across crates so, I append issue-32948's testcase to issue-32554's testcase. thanks!
michaelwoerister
commented
Oct 7, 2016
🎉 |
#32948
issue-32948 is similar to issue-32554.
issue-32948 : Symbol names for monomorphized trait impls are not stable across crates
issue-32554 : Symbol names for generics are not stable across crates
so, I append issue-32948's testcase to issue-32554's testcase.
thanks!