Uh oh!
There was an error while loading. Please reload this page.
fix pred_count accounting in SimplifyCfg - #36959
Merged
Merged
Conversation
eddyb
reviewed
Oct 4, 2016
Contributor
There was a problem hiding this comment.
Took me a while to get that this is because *start becomes dead here and thus shouldn't count.
There should be a comment making this (or whatever the correct explanation) clear to future readers.
eddyb
commented
Oct 4, 2016
Contributor
r=me with a comment added. |
arielb1force-pushed
the
simplify-cfg-fixes
branch
from
October 4, 2016 14:08
babdff1 to
44ac016Comparearielb1
commented
Oct 4, 2016
ContributorAuthor
@bors r=eddyb |
bors
commented
Oct 4, 2016
Collaborator
📌 Commit 44ac016 has been approved by |
eddyb
reviewed
Oct 4, 2016
| // goto -> bb1; | ||
| // } | ||
| // | ||
| // bb1: { |
arielb1
commented
Oct 4, 2016
ContributorAuthor
@bors r=eddyb |
bors
commented
Oct 4, 2016
Collaborator
📌 Commit bfdf437 has been approved by |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Oct 6, 2016
fix pred_count accounting in SimplifyCfg r? @eddyb
bors added a commit
that referenced
this pull request
Oct 6, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @eddyb