Uh oh!
There was an error while loading. Please reload this page.
Linker regression - #36960
Merged
Merged
Conversation
eddyb
commented
Oct 4, 2016
Contributor
@bors r+ Also, does this affect beta, i.e. do we need to backport this? |
bors
commented
Oct 4, 2016
Collaborator
📌 Commit 4570199 has been approved by |
michaelwoerister
commented
Oct 4, 2016
MemberAuthor
@bors r- The new code fails when the same shim is instantiated twice (can't define the same function two times). Will fix. |
michaelwoerister
commented
Oct 5, 2016
MemberAuthor
OK, the updated version passes |
eddyb
commented
Oct 5, 2016
Contributor
@bors r+ |
bors
commented
Oct 5, 2016
Collaborator
📌 Commit 2d34ad0 has been approved by |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Oct 6, 2016
… r=eddyb Linker regression This should fix the symbol conflicts reported in rust-lang#36852. The PR also makes some debug output a bit more informative. r? @eddyb
bors added a commit
that referenced
this pull request
Oct 6, 2016
nikomatsakis
commented
Oct 11, 2016
Contributor
Accepting for beta because small patch, regression. cc @rust-lang/compiler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the symbol conflicts reported in #36852.
The PR also makes some debug output a bit more informative.
r? @eddyb