Skip to content

Minor modifications in concurrency section of the Rust book - #36957

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikhilshagri:docs
Oct 6, 2016
Merged

Minor modifications in concurrency section of the Rust book#36957
bors merged 1 commit into
rust-lang:masterfrom
nikhilshagri:docs

Conversation

@nikhilshagri

@nikhilshagrinikhilshagri commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

frewsxcv
frewsxcv reviewed Oct 4, 2016
View reviewed changes
Comment threadsrc/doc/book/concurrency.md Outdated

@frewsxcvfrewsxcvOct 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very minor detail, but is it possible you could use the 'dash' character (—) instead of a 'hyphen' character (-) for this?

https://owl.english.purdue.edu/engagement/3/7/98/

@frewsxcv

frewsxcv commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

Minus the punctuation change, looks good to me!

@nikhilshagri

nikhilshagri commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

@frewsxcv Fixed it!

@frewsxcv

frewsxcv commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

Strange, it looks like there are two hyphens now. Do you also see that in the diff?

@nikhilshagri

nikhilshagri commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

It appears like that in the diff, but I think the two hyphens are automatically fused together to form a larger hyphen in the actual markdown page. I haven't checked yet.

@GuillaumeGomez

GuillaumeGomez commented Oct 4, 2016

Copy link
Copy Markdown
Member

I see them as two hyphens as well. Dark magic.

@nikhilshagri

nikhilshagri commented Oct 4, 2016

Copy link
Copy Markdown
ContributorAuthor

Fixed it. I was under the impression that the long dash is formed by joining the two small dashes. To rectify this, I actually copied the dash character from here and pasted it in the code because I wasn't able to find a way to type it from my keyboard 😅

@frewsxcv

frewsxcv commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

Looks great, thanks! r=me

@steveklabnik

steveklabnik commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

@bors: r=frewsxcv

Thanks so much @cynicaldevil !

(And yay to @frewsxcv 's first official docs review 🎊 )

@bors

bors commented Oct 4, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 335d393 has been approved by frewsxcv

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 6, 2016
Jonathan Turner
Rollup merge ofrust-lang#36957- cynicaldevil:docs, r=frewsxcv
534a2b5
Minor modifications in concurrency section of the Rust book
Fixesrust-lang#36939
r? @steveklabnik
@sophiajtsophiajt mentioned this pull request Oct 6, 2016
Merged
bors added a commit that referenced this pull request Oct 6, 2016
@bors
Auto merge of#37002- jonathandturner:rollup, r=jonathandturner
ad19c32
Rollup of 15 pull requests
- Successful merges: #36726, #36832, #36909, #36930, #36932, #36957, #36959, #36960, #36962, #36965, #36966, #36967, #36972, #36974, #36977
- Failed merges:
@bors
bors merged commit 335d393 into rust-lang:masterOct 6, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@frewsxcvfrewsxcvfrewsxcv left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikhilshagri@frewsxcv@GuillaumeGomez@steveklabnik@bors