travis: Fuchsia builder by petrhosek · Pull Request #39918 · rust-lang/rust

petrhosek · 2017-02-17T21:58:33Z

This change introduces a Dockerfile and script which builds a complete
Fuchsia toolchain which can be used to build Rust distribution for
Fuchsia. We only support cross-compiling at the moment, hence only
setting the target.

rust-highfive · 2017-02-17T21:58:46Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2017-02-18T00:25:53Z

We tend to prefer to pin to specific commits where possible to avoid an upstream commit accidentally breaking our build, could these clones all be followed with a cd $dir && git reset --hard $rev?
It should be fine to do a full clone, the Docker container is cached so we won't pay that build time on each build.

alexcrichton · 2017-02-18T00:26:35Z

I'm fine with this but if you'd prefer to just export AR_$target=llvm-ar that's also fine by me

alexcrichton · 2017-02-18T00:28:29Z

Right now we've actually got another similar container, cross above, which just builds a couple of targets that we release. Could you fold this container into that one and just add the targets there?
That container doesn't take too long to build so we should definitely be able to get a full build in under three hours, and that way we don't have to burn an extra slot on a new travis builder :)

alexcrichton · 2017-02-18T00:29:45Z

Looks great, thanks for the PR!

As one final piece, if you'd like, you can edit TARGETS in build-manifest with these Fuchsia targets. That way as soon as this merges and a new nightly happens everyone will be able to rustup target add Fuchsia

alexcrichton · 2017-02-18T00:32:18Z

Oh and one final thing. Travis limits our logs to 4MB maximum and it looks like 2 builds of clang and one build of LLVM may push us over that limit. We have a script floating around though to deal with this.

When folding this into the cross container, could you take a similar approach as the dist-x86-linux container with a shared.sh that contains this function which is copied in early and sourced at the start of scripts. Should be at least a little deduplication.

We'll worry later about deduplication across containers :)

petrhosek · 2017-02-18T18:20:33Z

All done, please take a look. It takes about 38 minutes to build on my machine, so hopefully it'll be under three hours on the Travis builder.

alexcrichton · 2017-02-21T15:01:42Z

Could you throw in a small comment to why a newer version of CMake is needed?
Also if switching to ubuntu 16.10 pulls in a new enough version it'd be ok to update to that as well.

CMake 3.8.0 is (going to) be the first version with Fuchsia support, RC1 was only released two weeks ago so I don't think it's available in any Linux distribution just yet. Do you want me to add the comment in this PR?

Sure yeah, that'd be great (just ping me and I'll re-r+)

alexcrichton · 2017-02-21T15:02:39Z

alexcrichton · 2017-02-21T15:02:55Z

@bors: r+

Looks great! We can always throw in the comments later :)

bors · 2017-02-21T15:02:56Z

📌 Commit decebdc has been approved by alexcrichton

petrhosek · 2017-02-21T20:35:31Z

Commend added.

alexcrichton · 2017-02-21T20:55:33Z

@bors: r+

bors · 2017-02-21T20:55:34Z

📌 Commit 18b0f88 has been approved by alexcrichton

travis: Fuchsia builder This change introduces a Dockerfile and script which builds a complete Fuchsia toolchain which can be used to build Rust distribution for Fuchsia. We only support cross-compiling at the moment, hence only setting the target.

Rollup of 11 pull requests - Successful merges: #39859, #39886, #39892, #39903, #39914, #39918, #39988, #40010, #40027, #40030, #40035 - Failed merges:

travis: Fuchsia builder This change introduces a Dockerfile and script which builds a complete Fuchsia toolchain which can be used to build Rust distribution for Fuchsia. We only support cross-compiling at the moment, hence only setting the target.

bors · 2017-02-25T15:00:53Z

⌛ Testing commit 18b0f88 with merge 7ae0561...

bors · 2017-02-25T15:10:09Z

💔 Test failed - status-travis

alexcrichton · 2017-02-25T18:41:34Z

@petrhosek is that maybe a typo'd rev for compiler-rt?

petrhosek · 2017-03-05T01:30:36Z

I split the Fuchsia toolchain into a separate builder again, can you take a look again and retry if it looks fine to you?

alexcrichton · 2017-03-06T16:13:23Z

@bors: r+

bors · 2017-03-06T16:13:24Z

📌 Commit a5eea01 has been approved by alexcrichton

bors · 2017-03-09T10:41:24Z

🔒 Merge conflict

frewsxcv · 2017-03-09T13:49:59Z

@bors retry

bors · 2017-03-09T13:50:03Z

🔒 Merge conflict

eddyb · 2017-03-09T13:57:10Z

@frewsxcv We're waiting for @alexcrichton to wake up and unbreak @bors, retrying won't help 😞.

alexcrichton · 2017-03-09T15:03:22Z

@bors: retry

bors · 2017-03-09T19:52:47Z

🔒 Merge conflict

alexcrichton · 2017-03-09T19:58:33Z

@bors: retry

bors · 2017-03-09T23:42:35Z

☔ The latest upstream changes (presumably #40382) made this pull request unmergeable. Please resolve the merge conflicts.

This change introduces a Dockerfile and script which builds a complete Fuchsia toolchain which can be used to build Rust distribution for Fuchsia. We only support cross-compiling at the moment, hence only setting the target.

alexcrichton · 2017-03-10T16:28:57Z

@bors: r+

bors · 2017-03-10T16:28:58Z

📌 Commit 9a84611 has been approved by alexcrichton

travis: Fuchsia builder This change introduces a Dockerfile and script which builds a complete Fuchsia toolchain which can be used to build Rust distribution for Fuchsia. We only support cross-compiling at the moment, hence only setting the target.

Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426

rust-highfive assigned alexcrichton Feb 17, 2017

petrhosek force-pushed the fuchsia-ci branch 2 times, most recently from bcf6476 to 2dc7528Compare February 18, 2017 00:13

alexcrichton reviewed Feb 18, 2017
View reviewed changes

petrhosek force-pushed the fuchsia-ci branch from 2dc7528 to e8253deCompare February 18, 2017 18:18

petrhosek force-pushed the fuchsia-ci branch from e8253de to decebdcCompare February 19, 2017 02:43

alexcrichton reviewed Feb 21, 2017
View reviewed changes

Comment threadsrc/ci/docker/cross/build-fuchsia.sh Outdated
alexcrichtonFeb 21, 2017
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍

petrhosek force-pushed the fuchsia-ci branch from decebdc to 18b0f88Compare February 21, 2017 20:35

frewsxcv mentioned this pull request Feb 23, 2017
Rollup of 11 pull requests #40045
Closed

bors added a commit that referenced this pull request Feb 23, 2017
Auto merge of#40045- frewsxcv:rollup, r=frewsxcv
dd1c546
Rollup of 11 pull requests - Successful merges: #39859, #39886, #39892, #39903, #39914, #39918, #39988, #40010, #40027, #40030, #40035 - Failed merges:

eddyb mentioned this pull request Feb 25, 2017
Rollup of 29 pull requests #40089
Closed

petrhosek force-pushed the fuchsia-ci branch 2 times, most recently from 67f934e to a5eea01Compare March 5, 2017 01:29

travis: Fuchsia builder
9a84611
This change introduces a Dockerfile and script which builds a complete Fuchsia toolchain which can be used to build Rust distribution for Fuchsia. We only support cross-compiling at the moment, hence only setting the target.

alexcrichton force-pushed the fuchsia-ci branch from a5eea01 to 9a84611Compare March 10, 2017 16:28

alexcrichton mentioned this pull request Mar 10, 2017
Rollup of 35 pull requests #40420
Closed

alexcrichton mentioned this pull request Mar 10, 2017
Rollup of 38 pull requests #40432
Merged

bors merged commit 9a84611 into rust-lang:masterMar 11, 2017

workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024

Uh oh!

Uh oh!

Conversation

petrhosek commented Feb 17, 2017

Uh oh!

rust-highfive commented Feb 17, 2017

Uh oh!

alexcrichtonFeb 18, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichtonFeb 18, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichtonFeb 18, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Feb 18, 2017

Uh oh!

alexcrichton commented Feb 18, 2017

Uh oh!

petrhosek commented Feb 18, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichtonFeb 21, 2017

Choose a reason for hiding this comment

Uh oh!

petrhosekFeb 21, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichtonFeb 21, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichtonFeb 21, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Feb 21, 2017

Uh oh!

bors commented Feb 21, 2017

Uh oh!

petrhosek commented Feb 21, 2017

Uh oh!

alexcrichton commented Feb 21, 2017

Uh oh!

bors commented Feb 21, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

alexcrichton commented Feb 25, 2017

Uh oh!

petrhosek commented Mar 5, 2017

Uh oh!

alexcrichton commented Mar 6, 2017

Uh oh!

bors commented Mar 6, 2017

Uh oh!

bors commented Mar 9, 2017

Uh oh!

frewsxcv commented Mar 9, 2017

Uh oh!

bors commented Mar 9, 2017

Uh oh!

eddyb commented Mar 9, 2017

Uh oh!

alexcrichton commented Mar 9, 2017

Uh oh!

bors commented Mar 9, 2017

Uh oh!

alexcrichton commented Mar 9, 2017

Uh oh!

bors commented Mar 9, 2017

Uh oh!

alexcrichton commented Mar 10, 2017

Uh oh!

bors commented Mar 10, 2017

Uh oh!

Reviewers

Assignees

Labels

petrhosek commented Feb 18, 2017•
edited
Loading