Skip to content

rustbuild: expose LLVM_PARALLEL_LINK_JOBS - #40277

Merged
bors merged 1 commit into
rust-lang:masterfrom
hanna-kruppe:llvm-parallel-link-jobs
Mar 11, 2017
Merged

rustbuild: expose LLVM_PARALLEL_LINK_JOBS#40277
bors merged 1 commit into
rust-lang:masterfrom
hanna-kruppe:llvm-parallel-link-jobs

Conversation

@hanna-kruppe

Copy link
Copy Markdown
Contributor

This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@hanna-kruppe

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

NB: This is untested, because rebuilding LLVM is a hassle on the machine I'm currently on (and MSVC may ignore it anyway).

@Mark-Simulacrum

Copy link
Copy Markdown
Member

For me, linking LLVM in parallel (-j8 for my number of cores) consumes more than 8 GB of memory, while building it never consumes more than ~2 GB, so it would be very nice to be able to build quickly (in parallel) but not link in parallel.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 202d8da has been approved by alexcrichton

@alexcrichton

Copy link
Copy Markdown
Member

Thanks @rkruppe!

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
…alexcrichton
rustbuild: expose LLVM_PARALLEL_LINK_JOBS
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
@frewsxcvfrewsxcv mentioned this pull request Mar 8, 2017
@bors

bors commented Mar 9, 2017

Copy link
Copy Markdown
Collaborator

🔒 Merge conflict

This allows limiting the number of linker jobs to avoid swapping when
linking LLVM with debug info.
@hanna-kruppe
hanna-kruppeforce-pushed the llvm-parallel-link-jobs branch from 202d8da to 58ff4f6CompareMarch 9, 2017 14:08
@hanna-kruppe

hanna-kruppe commented Mar 9, 2017

Copy link
Copy Markdown
ContributorAuthor

I have no idea what this "merge conflict" is about, I just rebased without conflicts?! Maybe that unwedges bors ¯\_(ツ)_/¯

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 58ff4f6 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 9, 2017
…alexcrichton
rustbuild: expose LLVM_PARALLEL_LINK_JOBS
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
@frewsxcvfrewsxcv mentioned this pull request Mar 9, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 9, 2017
…alexcrichton
rustbuild: expose LLVM_PARALLEL_LINK_JOBS
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
@frewsxcvfrewsxcv mentioned this pull request Mar 9, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
…alexcrichton
rustbuild: expose LLVM_PARALLEL_LINK_JOBS
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
…alexcrichton
rustbuild: expose LLVM_PARALLEL_LINK_JOBS
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
…alexcrichton
rustbuild: expose LLVM_PARALLEL_LINK_JOBS
This allows limiting the number of linker jobs to avoid swapping when linking LLVM with debug info.
@bors
bors merged commit 58ff4f6 into rust-lang:masterMar 11, 2017
@hanna-kruppe
hanna-kruppe deleted the llvm-parallel-link-jobs branch February 2, 2026 22:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@hanna-kruppe@rust-highfive@Mark-Simulacrum@alexcrichton@bors@brson