Skip to content

OsString::shrink_to_fit. - #40410

Merged
bors merged 1 commit into
rust-lang:masterfrom
clarfonthey:os_string_shrink_to_fit
Mar 11, 2017
Merged

OsString::shrink_to_fit.#40410
bors merged 1 commit into
rust-lang:masterfrom
clarfonthey:os_string_shrink_to_fit

Conversation

@clarfonthey

@clarfontheyclarfonthey commented Mar 10, 2017

Copy link
Copy Markdown
Contributor

Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.

Will create a tracking issue once I get an OK on this.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 10, 2017
@alexcrichton

Copy link
Copy Markdown
Member

Thanks! Could you file a tracking issue for this and I'll r+?

@clarfonthey
clarfontheyforce-pushed the os_string_shrink_to_fit branch from 3ab87ae to 83814fdCompareMarch 10, 2017 17:15
@clarfonthey

Copy link
Copy Markdown
ContributorAuthor

Filed and added!

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 10, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 83814fd has been approved by alexcrichton

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
…r=alexcrichton
OsString::shrink_to_fit.
Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.
Will create a tracking issue once I get an OK on this.
@arielb1arielb1 mentioned this pull request Mar 10, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
…r=alexcrichton
OsString::shrink_to_fit.
Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.
Will create a tracking issue once I get an OK on this.
@arielb1arielb1 mentioned this pull request Mar 10, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
…r=alexcrichton
OsString::shrink_to_fit.
Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.
Will create a tracking issue once I get an OK on this.
@arielb1arielb1 mentioned this pull request Mar 10, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
…r=alexcrichton
OsString::shrink_to_fit.
Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.
Will create a tracking issue once I get an OK on this.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
…r=alexcrichton
OsString::shrink_to_fit.
Considering how the other capacity-related methods are there, I found it odd that this one wasn't included.
Will create a tracking issue once I get an OK on this.
@bors
bors merged commit 83814fd into rust-lang:masterMar 11, 2017
@clarfonthey
clarfonthey deleted the os_string_shrink_to_fit branch March 11, 2017 19:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@clarfonthey@rust-highfive@alexcrichton@bors@brson@frewsxcv