Uh oh!
There was an error while loading. Please reload this page.
Rollup of 26 pull requests - #40595
Closed
frewsxcv wants to merge 81 commits into
Closed
Conversation
Primarily opened to address the concerns brought up in rust-lang#40498. * run rustfmt on code blocks * use `DefaultHasher` instead of deprecated `SipHasher` * rename `hash` to `calculate_hash` to prevent confusion with the `hash` method
We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
Whenever we parse a chain of binary operations, as long as the first operation is `<` and the subsequent operations are either `>` or `<`, present the following diagnostic help: use `::<...>` instead of `<...>` if you meant to specify type arguments This will lead to spurious recommendations on situations like `2 < 3 < 4` but should be clear from context that the help doesn't apply in that case.
Updating README.md to point to the correct doc location
Target builds for older macOS Fixrust-lang#40481
fix format grammar This is just a trivial change to get the escaped squigglies into the grammar. r? @steveklabnik
…rewsxcv Using X headings rust-lang#39850 Fix for issue rust-lang#39850, the headings should now be 1, 2, and 3.
…eGomez Fix sidebar not extending to the bottom of the page Fixesrust-lang#40459
Corrected very minor documentation detail about Unicode and Japanese
Japanese half-width and full-width romaji characters do have upper and lowercase according Unicode (but other Japanese characters do not). For example,
` assert_eq!('\u{FF21}'.to_lowercase().collect::<String>(),"\u{FF41}");`
r? @steveklabnikPoint out correct turbofish usage on `Foo<Bar<Baz>>` Whenever we parse a chain of binary operations, as long as the first operation is `<` and the subsequent operations are either `>` or `<`, present the following diagnostic help: use `::<...>` instead of `<...>` if you meant to specify type arguments This will lead to spurious recommendations on situations like `2 < 3 < 4` but should be clear from context that the help doesn't apply in that case. Fixesrust-lang#40396.
…sfackler std: remove a workaround for privacy limitations `std::thread::Thread` implements a non-exported `NewThread` trait to allow for internal-only use of `Thread::new`. Nowadays we have `pub(crate)`, which accomplishes the same thing but much more idiomatically. Rustdoc handles this correctly (I checked and I didn't see `Thread::new` on the rustdoc entry for `Thread` with this change), and the stage1 `rustc` emits the correct error still (I'm assuming that the stage1 compiler uses my `libstd`?): ``` $ ./build/x86_64-apple-darwin/stage1/bin/rustc test.rs error: method `new` is private --> test.rs:4:18 | 4 | let thread = thread::Thread::new(None); | ^^^^^^^^^^^^^^^^^^^ error: aborting due to previous error ```
A few improvements to the `core::hash` top-level docs. Primarily opened to address the concerns brought up in rust-lang#40498. * run rustfmt on code blocks * use `DefaultHasher` instead of deprecated `SipHasher` * rename `hash` to `calculate_hash` to prevent confusion with the `hash` method
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
.gitmodules: use official URLs w/o redirect
…excrichton Remove incorrect feature from the 1.16 relnotes According to @golddrankshttps://internals.rust-lang.org/t/rust-1-16-0-prerelease-testing/4953/3 r? @brson
…xcrichton Link core::slice to std::slice
Make docs required again Completely untested. Fixesrust-lang/rustup#903 r? @alexcrichton cc @steveklabnik
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
Library stabilizations for 1.17 Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17. Will need a beta backport, which I will create after approval. r? @alexcrichton
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
…, r=nikomatsakis rustbuild: Retry downloads of OpenSSL source We need this to compile Cargo and we download it at build time, but as like all other network requests it has a chance of failing. This commit moves the source of the tarball to a mirror (S3 seems semi-more-reliable most of the time) and also wraps the download in a retry loop. cc rust-lang#40474
Remove unused param from bootstrap::clean::rm_rf None
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
rust-highfive
commented
Mar 17, 2017
Contributor
Some changes occurred in HTML/CSS. |
rust-highfive
commented
Mar 17, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Mar 17, 2017
ContributorAuthor
@bors r+ p=10 |
bors
commented
Mar 17, 2017
Collaborator
📌 Commit 7569ddc has been approved by |
bors
commented
Mar 17, 2017
Collaborator
⌛ Testing commit 7569ddc with merge 716bffb... |
bors
commented
Mar 17, 2017
Collaborator
💔 Test failed - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srcforptr::write{,_unaligned}#40387, Add test for issue #29595 #40433, Add basic documentation/examples for six unstable features. #40452, Add doc examples forOsStr,OsString. #40458, some style fixes #40463, Updating README.md to point to the correct doc location #40467, Target builds for older macOS #40482, fix format grammar #40495, Using X headings #39850 #40496, Fix sidebar not extending to the bottom of the page #40497, Corrected very minor documentation detail about Unicode and Japanese #40499, Point out correct turbofish usage onFoo<Bar<Baz>>#40500, std: remove a workaround for privacy limitations #40503, A few improvements to thecore::hashtop-level docs. #40505, travis: Ensure cargo links libcurl statically #40507, .gitmodules: use official URLs w/o redirect #40512, Remove incorrect feature from the 1.16 relnotes #40517, Link core::slice to std::slice #40520, Make docs required again #40526, Fix documentation for Vec::dedup_by. #40536, Library stabilizations for 1.17 #40538, Removes Default for Box<Path>. #40539, rustbuild: Retry downloads of OpenSSL source #40545, Remove unused param from bootstrap::clean::rm_rf #40562, add sort_unstable to unstable book #40586