Target builds for older macOS by wagenet · Pull Request #40482 · rust-lang/rust

wagenet · 2017-03-13T18:37:40Z

rust-highfive · 2017-03-13T18:37:53Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2017-03-13T19:24:02Z

Is... travis not listening?

wagenet · 2017-03-13T19:32:28Z

@alexcrichton tried forcing a new commit to see if it picks it up.

mzji · 2017-03-13T19:38:44Z

Travis is missing pull requests: status

wagenet · 2017-03-14T14:18:52Z

So the tests run fine until they time-out after 3 hours. They're not stuck and are still making progress at this point.

alexcrichton · 2017-03-14T14:22:50Z

@wagenet oh right yeah sorry now that I think about it I don't think we've gotten macs-on-PRs working yet (for... reasons unknown).

In any case I think it got past everything just fine that it needed to (bootstrapping the compiler), so I think we're in the clear here for this PR as-is.

So this gets the compiler itself to 10.8 but libstd as well. Would you still like to get libstd to 10.7 in this PR or would you like to save that for a follow-up PR?

alexcrichton · 2017-03-14T14:24:33Z

I'm also flagging this for a backport to beta as #40481 affects beta

alexcrichton · 2017-03-14T15:28:07Z

@bors: r+

bors · 2017-03-14T15:28:08Z

📌 Commit 01ffac5 has been approved by alexcrichton

alexcrichton · 2017-03-14T15:28:26Z

@bors: r-

Oh actually can the ALLOW_PR=1 be removed?

alexcrichton · 2017-03-14T17:13:32Z

@bors: r+

bors · 2017-03-14T17:13:34Z

📌 Commit 61d9387 has been approved by alexcrichton

alexcrichton · 2017-03-15T14:59:52Z

@bors: p=1

(beta nominated)

bors · 2017-03-16T03:44:15Z

⌛ Testing commit 61d9387 with merge e897fcb...

Target builds for older macOS Fixrust-lang#40481

bors · 2017-03-17T04:44:16Z

⌛ Testing commit 61d9387 with merge a7c2247...

bors · 2017-03-17T05:14:08Z

💔 Test failed - status-travis

alexcrichton · 2017-03-17T14:14:09Z

@bors: retry * spurious sccache failure #40240

…

On Fri, Mar 17, 2017 at 12:14 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/212004552> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40482 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95Ghq8sAHiuOwVYJJ_SUHdgeIfPoBks5rmhaigaJpZM4Mbpzw> .

Target builds for older macOS Fixrust-lang#40481

[beta] Backports to beta This is a backport of the following PRs to beta: * #40507 * #40482 * #40526 * #40539 * #40538

Target builds for older macOS Fixrust-lang#40481

bors · 2017-03-18T00:40:13Z

⌛ Testing commit 61d9387 with merge 703b246...

Target builds for older macOS Fix#40481

bors · 2017-03-18T03:31:54Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 703b246 to master...

rust-highfive assigned alexcrichton Mar 13, 2017

alexcrichton closed this Mar 13, 2017

alexcrichton reopened this Mar 13, 2017

wagenet force-pushed the fix-old-macos branch from 0f718ce to c12a20aCompare March 13, 2017 19:31

wagenet closed this Mar 13, 2017

wagenet reopened this Mar 13, 2017

wagenet closed this Mar 13, 2017

wagenet reopened this Mar 13, 2017

wagenet mentioned this pull request Mar 13, 2017
Target builds for older macOS #40489
Closed

wagenet force-pushed the fix-old-macos branch from c12a20a to 0cb9c0eCompare March 13, 2017 22:45

alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 14, 2017

wagenet force-pushed the fix-old-macos branch from c194a71 to 01ffac5Compare March 14, 2017 15:26

wagenet force-pushed the fix-old-macos branch from 01ffac5 to 8b9e14cCompare March 14, 2017 16:08

Target builds for older macOS
61d9387

wagenet force-pushed the fix-old-macos branch from 8b9e14c to 61d9387Compare March 14, 2017 17:08

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 26 pull requests #40591
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40482- wagenet:fix-old-macos, r=alexcrichton
39bca2d
Target builds for older macOS Fixrust-lang#40481

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 26 pull requests #40592
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40482- wagenet:fix-old-macos, r=alexcrichton
b5a5ee4
Target builds for older macOS Fixrust-lang#40481

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 26 pull requests #40595
Closed

alexcrichton mentioned this pull request Mar 17, 2017
[beta] Backports to beta #40600
Merged

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40482- wagenet:fix-old-macos, r=alexcrichton
0644fae
Target builds for older macOS Fixrust-lang#40481

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 15 pull requests #40615
Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40482- wagenet:fix-old-macos, r=alexcrichton
6242e2f
Target builds for older macOS Fixrust-lang#40481

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 16 pull requests #40616
Closed

bors added a commit that referenced this pull request Mar 17, 2017
Auto merge of#40600- alexcrichton:beta-next, r=alexcrichton
456ca95
[beta] Backports to beta This is a backport of the following PRs to beta: * #40507 * #40482 * #40526 * #40539 * #40538

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
Rollup merge ofrust-lang#40482- wagenet:fix-old-macos, r=alexcrichton
4b63f47
Target builds for older macOS Fixrust-lang#40481

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 12 pull requests #40618
Closed

bors added a commit that referenced this pull request Mar 18, 2017
Auto merge of#40482- wagenet:fix-old-macos, r=alexcrichton
703b246
Target builds for older macOS Fix#40481

bors merged commit 61d9387 into rust-lang:masterMar 18, 2017

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 20, 2017

This was referenced Jul 15, 2017
Potential double close in PtyMaster nix-rust/nix#659
Closed
Implement AsRawFd/IntoRawFd for RawFd #43254
Closed

Uh oh!

Uh oh!

Conversation

wagenet commented Mar 13, 2017

Uh oh!

rust-highfive commented Mar 13, 2017

Uh oh!

alexcrichton commented Mar 13, 2017

Uh oh!

wagenet commented Mar 13, 2017

Uh oh!

mzji commented Mar 13, 2017

Uh oh!

wagenet commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 14, 2017

Uh oh!

bors commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 14, 2017

Uh oh!

bors commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 15, 2017

Uh oh!

bors commented Mar 16, 2017

Uh oh!

bors commented Mar 17, 2017

Uh oh!

bors commented Mar 17, 2017

Uh oh!

alexcrichton commented Mar 17, 2017 via email

Uh oh!

bors commented Mar 18, 2017

Uh oh!

bors commented Mar 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants