Uh oh!
There was an error while loading. Please reload this page.
travis: Ensure cargo links libcurl statically - #40507
Merged
Merged
Conversation
We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
rust-highfive
commented
Mar 14, 2017
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Mar 14, 2017
MemberAuthor
This is a regession from nightly, so nominating for beta as well. |
brson
commented
Mar 14, 2017
Contributor
@bors r+ |
bors
commented
Mar 14, 2017
Collaborator
📌 Commit 5fab9bf has been approved by |
alexcrichton
commented
Mar 14, 2017
MemberAuthor
@bors: p=1 (fixing nightly) |
bors
commented
Mar 15, 2017
Collaborator
⌛ Testing commit 5fab9bf with merge 6d38130... |
bors
commented
Mar 15, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Mar 15, 2017
MemberAuthor
@bors: retry
|
Arzte
commented
Mar 15, 2017
Contributor
@alexcrichton Looks like bors failed, could you retry it? |
alexcrichton
commented
Mar 15, 2017
MemberAuthor
@SirDoctors ah yeah that's what my previous comment is doing. |
bors added a commit
that referenced
this pull request
Mar 16, 2017
[beta] travis: Ensure cargo links libcurl statically This is a beta backport of #40507
bors
commented
Mar 16, 2017
Collaborator
⌛ Testing commit 5fab9bf with merge 12cc8da... |
bors
commented
Mar 16, 2017
Collaborator
💔 Test failed - status-appveyor |
alexcrichton
commented
Mar 16, 2017
via email
MemberAuthor
| … On Thu, Mar 16, 2017 at 9:03 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2406>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40507 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AMudN6LXqS_T6JLceJkJBK2aWR-ks5rmUEpgaJpZM4McIrS>
.
|
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
bors
commented
Mar 17, 2017
Collaborator
⌛ Testing commit 5fab9bf with merge 2e540cd... |
bors
commented
Mar 17, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Mar 17, 2017
MemberAuthor
alexcrichton
commented
Mar 17, 2017
MemberAuthor
@bors: retry
|
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
bors
commented
Mar 18, 2017
Collaborator
bors added a commit
that referenced
this pull request
Mar 18, 2017
travis: Ensure cargo links libcurl statically We don't want a dynamic dependency in the library that we ship, so link it statically by configuring curl-sys's build script to not pick up the system version via pkg-config.
bors
commented
Mar 18, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Arzte
commented
Mar 18, 2017
Contributor
woot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want a dynamic dependency in the library that we ship, so link it
statically by configuring curl-sys's build script to not pick up the system
version via pkg-config.