Uh oh!
There was an error while loading. Please reload this page.
Removes Default for Box<Path>. - #40539
Merged
Merged
Conversation
rust-highfive
commented
Mar 15, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Mar 15, 2017
Collaborator
☔ The latest upstream changes (presumably #40009) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
Mar 15, 2017
Member
Looks great to me, thanks! r=me with a rebase |
clarfontheyforce-pushed
the
no_default_path
branch
from
March 15, 2017 14:54
8600ccf to
5e2d592Compareclarfonthey
commented
Mar 15, 2017
ContributorAuthor
Just rebased, should work now! |
alexcrichton
commented
Mar 15, 2017
Member
@bors: r+ p=1 (beta nominated) |
bors
commented
Mar 15, 2017
Collaborator
📌 Commit 5e2d592 has been approved by |
alexcrichton
commented
Mar 15, 2017
Member
@clarcharr according to #40550 a test may need an update as well? |
clarfontheyforce-pushed
the
no_default_path
branch
from
March 15, 2017 15:36
5e2d592 to
0739eceCompareclarfonthey
commented
Mar 15, 2017
ContributorAuthor
Oh, whoops. Updated the PR. |
alexcrichton
commented
Mar 15, 2017
Member
@bors: r+ |
bors
commented
Mar 15, 2017
Collaborator
📌 Commit 0739ece has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 17, 2017
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
bors
commented
Mar 17, 2017
Collaborator
bors added a commit
that referenced
this pull request
Mar 17, 2017
Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
bors
commented
Mar 17, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not supposed to be added. cc @alexcrichton