Skip to content

Stabilize non capturing closure to fn coercion - #42162

Closed
est31 wants to merge 1 commit into
rust-lang:masterfrom
est31:closure-to-fn-coercion
Closed

Stabilize non capturing closure to fn coercion#42162
est31 wants to merge 1 commit into
rust-lang:masterfrom
est31:closure-to-fn-coercion

Conversation

@est31

@est31est31 commented May 23, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Stabilisation PR for non capturing closure to fn coercion.

closes#39817

@rust-highfive

rust-highfive commented May 23, 2017

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

bors commented May 23, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #42165) made this pull request unmergeable. Please resolve the merge conflicts.

@est31
est31force-pushed the closure-to-fn-coercion branch from 6c299ba to 8b4a590CompareMay 23, 2017 12:59
@arielb1arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-team T-lang Relevant to the language team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2017
@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #41145) made this pull request unmergeable. Please resolve the merge conflicts.

@est31
est31force-pushed the closure-to-fn-coercion branch from 8b4a590 to 87950b7CompareMay 25, 2017 09:58
@steveklabnik

steveklabnik commented May 26, 2017

Copy link
Copy Markdown
Contributor

all the other criteria needed for stabilisation are met.

Docs criteria is met.

@est31

est31 commented May 26, 2017

Copy link
Copy Markdown
MemberAuthor

As agreed to on IRC, asking for early review (before the remaining 7 days of FCP are over) due to the branch date of beta in 7 days, otherwise the feature might not make it into 1.19. We can always back out later.

r? @aturon

@rust-highfiverust-highfive assigned aturon and unassigned pnkfelixMay 26, 2017
@aturon

aturon commented May 27, 2017

Copy link
Copy Markdown
Contributor

Let's go ahead and get this into the queue.

@bors: r+

@bors

bors commented May 27, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 87950b7 has been approved by aturon

@shepmastershepmaster added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels May 27, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42162- est31:closure-to-fn-coercion, r=aturon
05d94c8
Stabilize non capturing closure to fn coercion
Stabilisation PR for non capturing closure to fn coercion.
closesrust-lang#39817
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 27, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 27, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42162- est31:closure-to-fn-coercion, r=aturon
d11e112
Stabilize non capturing closure to fn coercion
Stabilisation PR for non capturing closure to fn coercion.
closesrust-lang#39817
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 27, 2017
Closed
bors added a commit that referenced this pull request May 27, 2017
@bors
Auto merge of#42258- Mark-Simulacrum:rollup, r=Mark-Simulacrum
5712e03
Rollup of 10 pull requests
- Successful merges: #42103, #42137, #42162, #42167, #42175, #42207, #42217, #42246, #42249, #42251
- Failed merges:
@bors

bors commented May 27, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 87950b7 with merge 5d2512e...

bors added a commit that referenced this pull request May 27, 2017
@bors
Auto merge of#42162- est31:closure-to-fn-coercion, r=aturon
5d2512e
Stabilize non capturing closure to fn coercion
Stabilisation PR for non capturing closure to fn coercion.
closes#39817
@bors

bors commented May 28, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 5d2512e to master...

@est31

est31 commented May 28, 2017

Copy link
Copy Markdown
MemberAuthor

It got merged yeey!

I'm not sure though why the PR doesn't get shown as "merged" by this. Github bug?

@est31est31 closed this May 28, 2017
@Mark-Simulacrum

Mark-Simulacrum commented May 28, 2017

Copy link
Copy Markdown
Member

GH seems to recognize that it is merged afterwards though; I can't reopen -- "commits are already merged"

@dwrenshadwrensha mentioned this pull request May 30, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-langRelevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for RFC 1558: Allow coercing non-capturing closures to function pointers

9 participants

@est31@rust-highfive@bors@steveklabnik@aturon@Mark-Simulacrum@pnkfelix@shepmaster@arielb1