Uh oh!
There was an error while loading. Please reload this page.
Override size_hint and propagate ExactSizeIterator for iter::StepBy - #42167
Merged
Conversation
Generally useful, but also a prerequisite for moving a bunch of unit tests off Range::step_by.
alexcrichton
commented
May 23, 2017
Member
@bors: r+ Thanks! |
bors
commented
May 23, 2017
Collaborator
📌 Commit fcb3a71 has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 23, 2017
…excrichton Override size_hint and propagate ExactSizeIterator for iter::StepBy Generally useful, but also a prerequisite for moving a bunch of unit tests off `Range*::step_by`. A small non-breaking subset of rust-lang#42110 (which I closed). Includes two small documentation changes @ivandardi requested on that PR. r? @alexcrichton
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 24, 2017
…excrichton Override size_hint and propagate ExactSizeIterator for iter::StepBy Generally useful, but also a prerequisite for moving a bunch of unit tests off `Range*::step_by`. A small non-breaking subset of rust-lang#42110 (which I closed). Includes two small documentation changes @ivandardi requested on that PR. r? @alexcrichton
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 26, 2017
…excrichton Override size_hint and propagate ExactSizeIterator for iter::StepBy Generally useful, but also a prerequisite for moving a bunch of unit tests off `Range*::step_by`. A small non-breaking subset of rust-lang#42110 (which I closed). Includes two small documentation changes @ivandardi requested on that PR. r? @alexcrichton
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 27, 2017
…excrichton Override size_hint and propagate ExactSizeIterator for iter::StepBy Generally useful, but also a prerequisite for moving a bunch of unit tests off `Range*::step_by`. A small non-breaking subset of rust-lang#42110 (which I closed). Includes two small documentation changes @ivandardi requested on that PR. r? @alexcrichton
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 27, 2017
…excrichton Override size_hint and propagate ExactSizeIterator for iter::StepBy Generally useful, but also a prerequisite for moving a bunch of unit tests off `Range*::step_by`. A small non-breaking subset of rust-lang#42110 (which I closed). Includes two small documentation changes @ivandardi requested on that PR. r? @alexcrichton
bors
commented
May 28, 2017
Collaborator
⌛ Testing commit fcb3a71 with merge fca637b... |
bors
commented
May 28, 2017
Collaborator
💔 Test failed - status-travis |
ishitatsuyuki
commented
May 28, 2017
Contributor
#travissucks WTF OSX spinup timeout error... Maybe contact support. cc @alexcrichton |
Mark-Simulacrum
commented
May 28, 2017
Member
@bors retry It's a known problem. |
bors
commented
May 28, 2017
Collaborator
bors added a commit
that referenced
this pull request
May 28, 2017
Override size_hint and propagate ExactSizeIterator for iter::StepBy Generally useful, but also a prerequisite for moving a bunch of unit tests off `Range*::step_by`. A small non-breaking subset of #42110 (which I closed). Includes two small documentation changes @ivandardi requested on that PR. r? @alexcrichton
bors
commented
May 28, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally useful, but also a prerequisite for moving a bunch of unit tests off
Range*::step_by.A small non-breaking subset of #42110 (which I closed).
Includes two small documentation changes @ivandardi requested on that PR.
r? @alexcrichton