Skip to content

Add --all flag to ./x.py clean - #44694

Closed
tommyip wants to merge 2 commits into
rust-lang:masterfrom
tommyip:make_clean
Closed

Add --all flag to ./x.py clean#44694
tommyip wants to merge 2 commits into
rust-lang:masterfrom
tommyip:make_clean

Conversation

@tommyip

@tommyiptommyip commented Sep 19, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

This make clean removes the LLVM and download cache directory as well.

Fixes#44214.

r? @Mark-Simulacrum

@oli-obk

oli-obk commented Sep 19, 2017

Copy link
Copy Markdown
Contributor

Can we have a less nuclear option, too? After a rebase I frequently need to clean, but I really want to keep llvm.

@petrochenkov

petrochenkov commented Sep 19, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

IIRC, the old build system had clean and clean-all removing everything-except-for-LLVM and everything, respectively.

@Mark-Simulacrum

Mark-Simulacrum commented Sep 19, 2017

Copy link
Copy Markdown
Member

@tommyip Would you be up to adding an additional subcommand to bootstrap (clean-all) that removes build and tmp and then leaving the existing clean as-is? I think that would satisfy all parties involved.

Such a step would need to be taken in src/bootstrap/flags, probably threading through into config and maybe a few other places -- I can provide more detailed instructions if you want them; let me know!

@arielb1arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 19, 2017
@tommyip

tommyip commented Sep 19, 2017

Copy link
Copy Markdown
ContributorAuthor

Sure I will have a go at that tomorrow.

@tommyip

tommyip commented Sep 20, 2017

Copy link
Copy Markdown
ContributorAuthor

Do we want clean --all or just clean-all?

@Mark-Simulacrum

Mark-Simulacrum commented Sep 20, 2017

Copy link
Copy Markdown
Member

I'm fine with either. Can you also update the documentation for clean? It won't take target/host etc anymore.

@tommyip
Add --all flag to ./x.py clean
2c78bb4
This flag removes all build artifacts, including the LLVM build
directory.
@tommyip

tommyip commented Sep 20, 2017

Copy link
Copy Markdown
ContributorAuthor

Where is that documentation?

@tommyiptommyip changed the title Clean all build artifacts when running ./x.py cleanAdd --all flag to ./x.py cleanSep 20, 2017
@tommyip
tommyipforce-pushed the make_clean branch 2 times, most recently from 05aa486 to 779f3c1CompareSeptember 20, 2017 21:09
@tommyip

tommyip commented Sep 25, 2017

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum This PR is ready for review.

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 25, 2017
@Mark-Simulacrum

Mark-Simulacrum commented Sep 25, 2017

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Sep 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 09d90e5 has been approved by Mark-Simulacrum

@arielb1arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#44694- tommyip:make_clean, r=Mark-Simulacrum
6bc8ca0
Add --all flag to ./x.py clean
This make `clean` removes the LLVM and download cache directory as well.
Fixesrust-lang#44214.
r? @Mark-Simulacrum
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Sep 29, 2017
Closed
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of#44936- Mark-Simulacrum:rollup, r=Mark-Simulacrum
c4cca3a
Rollup of 15 pull requests
- Successful merges: #44124, #44287, #44320, #44694, #44708, #44794, #44797, #44824, #44836, #44840, #44845, #44854, #44889, #44900, #44903
- Failed merges:
@bors

bors commented Sep 30, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

Mark-Simulacrum commented Sep 30, 2017

Copy link
Copy Markdown
Member

Merged in #44936.

@tommyip
tommyip deleted the make_clean branch September 30, 2017 15:04
@kennytmkennytm mentioned this pull request Dec 25, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tommyip@oli-obk@petrochenkov@Mark-Simulacrum@bors@arielb1