Skip to content

Move src/librustc_mir/transform/nll.rs to a subdirectory - #44845

Closed
SimonSapin wants to merge 1 commit into
rust-lang:masterfrom
SimonSapin:nll_mod_rs
Closed

Move src/librustc_mir/transform/nll.rs to a subdirectory#44845
SimonSapin wants to merge 1 commit into
rust-lang:masterfrom
SimonSapin:nll_mod_rs

Conversation

@SimonSapin

@SimonSapinSimonSapin commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis

nikomatsakis commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 20d4c0f has been approved by nikomatsakis

@nikomatsakisnikomatsakis mentioned this pull request Sep 25, 2017
Closed
23 tasks
@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2017
@nikomatsakisnikomatsakis added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2017
@Nashenas88Nashenas88 mentioned this pull request Sep 27, 2017
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#44845- SimonSapin:nll_mod_rs, r=nikomatsakis
7c3d376
Move src/librustc_mir/transform/nll.rs to a subdirectory
CC rust-lang#43234
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Sep 29, 2017
Closed
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of#44936- Mark-Simulacrum:rollup, r=Mark-Simulacrum
c4cca3a
Rollup of 15 pull requests
- Successful merges: #44124, #44287, #44320, #44694, #44708, #44794, #44797, #44824, #44836, #44840, #44845, #44854, #44889, #44900, #44903
- Failed merges:
@bors

bors commented Sep 30, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

Mark-Simulacrum commented Sep 30, 2017

Copy link
Copy Markdown
Member

Merged in #44936.

@SimonSapin
SimonSapin deleted the nll_mod_rs branch November 16, 2017 17:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SimonSapin@rust-highfive@nikomatsakis@bors@Mark-Simulacrum@arielb1