Skip to content

Add new warning for CStr::from_ptr - #48507

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:cstr-note
Mar 6, 2018
Merged

Add new warning for CStr::from_ptr#48507
alexcrichton merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:cstr-note

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Feb 24, 2018

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2018
@kennytmkennytm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Feb 25, 2018
@shepmaster

shepmaster commented Mar 2, 2018

Copy link
Copy Markdown
Member

Ping from triage, @steveklabnik !

@steveklabnik

steveklabnik commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

I am not likely to be able to review until late tomorrow, possibly tuesday. Sorry about that!

@steveklabnik

steveklabnik commented Mar 6, 2018

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Mar 6, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 5344b07 has been approved by steveklabnik

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2018
@kennytmkennytm mentioned this pull request Mar 6, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#48507- GuillaumeGomez:cstr-note, r=stevekl…
75bc23d
…abnik
Add new warning for CStr::from_ptr
Fixesrust-lang#48401.
r? @steveklabnik
@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
@kennytm
Rollup merge ofrust-lang#48507- GuillaumeGomez:cstr-note, r=stevekl…
ebc6d6e
…abnik
Add new warning for CStr::from_ptr
Fixesrust-lang#48401.
bors added a commit that referenced this pull request Mar 6, 2018
@bors
Auto merge of#48768- kennytm:rollup, r=kennytm
2789b06
Rollup of 14 pull requests
- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton
alexcrichton merged commit 5344b07 into rust-lang:masterMar 6, 2018
@GuillaumeGomez
GuillaumeGomez deleted the cstr-note branch March 6, 2018 19:30
@me1iissame1iissa mentioned this pull request May 20, 2026
Merged
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabniksteveklabnik

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez@shepmaster@steveklabnik@bors@alexcrichton@kennytm@rust-highfive