Skip to content

Remove useless powerpc64 entry from ARCH_TABLE - #48732

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
debris:remove_powerpc64
Mar 6, 2018
Merged

Remove useless powerpc64 entry from ARCH_TABLE#48732
alexcrichton merged 1 commit into
rust-lang:masterfrom
debris:remove_powerpc64

Conversation

@debris

@debrisdebris commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Hope, I understood the scope of the fix correctly. closes#47737

@rust-highfive

rust-highfive commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2018
@hanna-kruppehanna-kruppe mentioned this pull request Mar 4, 2018
Closed
@alexcrichton

alexcrichton commented Mar 4, 2018

Copy link
Copy Markdown
Member

@bors: r+ rollup

Thanks!

@bors

bors commented Mar 4, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 16ac85c has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2018
@nagisa

nagisa commented Mar 4, 2018

Copy link
Copy Markdown
Member

I do not think this is an appropriate fix. #47737 (comment) matches my intuition well.

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2018
@Manishearth
Rollup merge ofrust-lang#48732- debris:remove_powerpc64, r=alexcric…
895ab22
…hton
Remove useless powerpc64 entry from ARCH_TABLE
Hope, I understood the scope of the fix correctly. closesrust-lang#47737
@ManishearthManishearth mentioned this pull request Mar 5, 2018
Closed
@kennytmkennytm mentioned this pull request Mar 6, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#48732- debris:remove_powerpc64, r=alexcric…
6b05c48
…hton
Remove useless powerpc64 entry from ARCH_TABLE
Hope, I understood the scope of the fix correctly. closesrust-lang#47737
@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#48732- debris:remove_powerpc64, r=alexcric…
64cb871
…hton
Remove useless powerpc64 entry from ARCH_TABLE
Hope, I understood the scope of the fix correctly. closesrust-lang#47737
@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
@kennytm
Rollup merge ofrust-lang#48732- debris:remove_powerpc64, r=alexcric…
178b2c4
…hton
Remove useless powerpc64 entry from ARCH_TABLE
Hope, I understood the scope of the fix correctly. closesrust-lang#47737
bors added a commit that referenced this pull request Mar 6, 2018
@bors
Auto merge of#48768- kennytm:rollup, r=kennytm
2789b06
Rollup of 14 pull requests
- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton
alexcrichton merged commit 16ac85c into rust-lang:masterMar 6, 2018
@debris
debris deleted the remove_powerpc64 branch March 6, 2018 20:00
@hanna-kruppehanna-kruppe mentioned this pull request Mar 9, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compiletest powerpc64 arch is useless

5 participants

@debris@rust-highfive@alexcrichton@bors@nagisa