Skip to content

doc: no need for the reference - #48590

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
tshepang:more-simple
Mar 6, 2018
Merged

doc: no need for the reference#48590
alexcrichton merged 1 commit into
rust-lang:masterfrom
tshepang:more-simple

Conversation

@tshepang

@tshepangtshepang commented Feb 27, 2018

Copy link
Copy Markdown
Member

Also, we are well within line length limit

@kennytmkennytm added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@kennytm

kennytm commented Feb 28, 2018

Copy link
Copy Markdown
Member

Thanks for the PR @tshepang!

Would you mind changing the code at line 1592 too?

The examples for .inspect() (lines 1184 and 1193), .by_ref() (lines 1234 and 1250), .collect() (lines 1291, 1308, 1322 and 1347) and .partition() (line 1397) may also be updated.

(The & for try_fold() needs to be kept though)

@tshepang
doc: no need for the references
df8dd3f
Also:
- apply some rustfmt love
- fix output of one example
@tshepang

tshepang commented Feb 28, 2018

Copy link
Copy Markdown
MemberAuthor

Thanks for the thorough checking... I hopes I fixed it all.

@emilyalbini

emilyalbini commented Mar 5, 2018

Copy link
Copy Markdown
Member

Ping from the release team. This PR doesn't have any assigned reviewer, assigning someone randomly from the docs team.

r? @frewsxcv

@frewsxcv

frewsxcv commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

looks great, thanks!

@bors r+ rollup

@bors

bors commented Mar 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit df8dd3f has been approved by frewsxcv

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
@kennytm
Rollup merge ofrust-lang#48590- tshepang:more-simple, r=frewsxcv
6b8984d
doc: no need for the reference
Also, we are well within line length limit
@kennytmkennytm mentioned this pull request Mar 6, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#48590- tshepang:more-simple, r=frewsxcv
05c1bb9
doc: no need for the reference
Also, we are well within line length limit
@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge ofrust-lang#48590- tshepang:more-simple, r=frewsxcv
11b3e72
doc: no need for the reference
Also, we are well within line length limit
@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
bors added a commit that referenced this pull request Mar 6, 2018
@bors
Auto merge of#48768- kennytm:rollup, r=kennytm
2789b06
Rollup of 14 pull requests
- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton
alexcrichton merged commit df8dd3f into rust-lang:masterMar 6, 2018
@tshepang
tshepang deleted the more-simple branch March 6, 2018 20:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@frewsxcvfrewsxcv

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tshepang@kennytm@emilyalbini@frewsxcv@bors@alexcrichton