Uh oh!
There was an error while loading. Please reload this page.
Raw string error note - #48546
Merged
alexcrichton merged 1 commit intoMar 6, 2018
Merged
Conversation
rust-highfive
commented
Feb 26, 2018
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomezforce-pushed
the
raw-string-error-note
branch
from
February 26, 2018 14:06
2135a57 to
b4ee47dComparevarkor
reviewed
Feb 26, 2018
Contributor
There was a problem hiding this comment.
Nit: should be newline-terminated.
eddyb
commented
Feb 26, 2018
Contributor
GuillaumeGomezforce-pushed
the
raw-string-error-note
branch
from
February 26, 2018 14:40
b4ee47d to
74f1489CompareContributor
There was a problem hiding this comment.
The span should really only point at the first char and have a span label:
error: unterminated raw string
--> $DIR/raw_string.rs:12:13
|
12 | let x = r##"lol"#;
| ^ unterminated raw string
|
= note: this raw string must be terminated with `"##`
estebank
commented
Feb 27, 2018
Contributor
Other than the nitpick, r=me |
nikomatsakis
commented
Feb 27, 2018
Contributor
r? @estebank |
GuillaumeGomezforce-pushed
the
raw-string-error-note
branch
from
March 4, 2018 13:37
74f1489 to
1c191b2CompareGuillaumeGomez
commented
Mar 4, 2018
MemberAuthor
Updated. |
estebank
approved these changes
Mar 4, 2018
estebank
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, r=me after addressing the nit-pick.
| self.fatal_span_(from_pos, to_pos, &m[..]) | ||
| } | ||
| fn struct_span_fatal(&self, |
Contributor
There was a problem hiding this comment.
Is this method necessary after the last change?
Contributor
There was a problem hiding this comment.
Isn't it being used only in fail_unterminated_raw_string above? The span for the error and the span_label could be made only once (self.mk_span(pos, pos)) and the message and label literal could be the same variable.
estebank
commented
Mar 5, 2018
Contributor
@bors r+ rollup |
bors
commented
Mar 5, 2018
Collaborator
📌 Commit 1c191b2 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Mar 6, 2018
…e, r=estebank Raw string error note Fixesrust-lang#48395. I think this note should be helpful enough to solve the issue.
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2018
…e, r=estebank Raw string error note Fixesrust-lang#48395. I think this note should be helpful enough to solve the issue.
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 6, 2018
…e, r=estebank Raw string error note Fixesrust-lang#48395. I think this note should be helpful enough to solve the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#48395.
I think this note should be helpful enough to solve the issue.