Skip to content

Always print aborting due to n previous error(s) - #49046

Merged
bors merged 4 commits into
rust-lang:masterfrom
Zoxc:error-summary
Mar 24, 2018
Merged

Always print aborting due to n previous error(s)#49046
bors merged 4 commits into
rust-lang:masterfrom
Zoxc:error-summary

Conversation

@Zoxc

@ZoxcZoxc commented Mar 15, 2018

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2018
@bors

bors commented Mar 16, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #49051) made this pull request unmergeable. Please resolve the merge conflicts.

@michaelwoerister

michaelwoerister commented Mar 19, 2018

Copy link
Copy Markdown
Member

@estebank, could you take a look at the last commit (b1d872b)? This PR changes diagnostics output and I'd like to make sure that that's OK.

@estebank

estebank commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@michaelwoerister LGTM++

@michaelwoerister

michaelwoerister commented Mar 20, 2018

Copy link
Copy Markdown
Member

Looks good to me too! There seems to be some overlap with #49030 though. I'll just approve for now. A merge conflict should be the worst that can happen.

@bors r+

@bors

bors commented Mar 20, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit b1d872b has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2018
@frewsxcv
Rollup merge ofrust-lang#49046- Zoxc:error-summary, r=michaelwoerister
0616e86
Always print `aborting due to n previous error(s)`
r? @michaelwoerister
@frewsxcvfrewsxcv mentioned this pull request Mar 23, 2018
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2018
@frewsxcv
Rollup merge ofrust-lang#49046- Zoxc:error-summary, r=michaelwoerister
a10dd4d
Always print `aborting due to n previous error(s)`
r? @michaelwoerister
@frewsxcvfrewsxcv mentioned this pull request Mar 23, 2018
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge ofrust-lang#49046- Zoxc:error-summary, r=michaelwoerister
19f8431
Always print `aborting due to n previous error(s)`
r? @michaelwoerister
@alexcrichtonalexcrichton mentioned this pull request Mar 23, 2018
Closed
@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b1d872b with merge 5a6820b548e20d6ef17ab367b51e33e659ee4143...

@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2018
@kennytm

kennytm commented Mar 24, 2018

Copy link
Copy Markdown
Member

@bors retry #43283

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge ofrust-lang#49046- Zoxc:error-summary, r=michaelwoerister
0acfcb8
Always print `aborting due to n previous error(s)`
@kennytmkennytm mentioned this pull request Mar 24, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge ofrust-lang#49046- Zoxc:error-summary, r=michaelwoerister
9c5f372
Always print `aborting due to n previous error(s)`
r? @michaelwoerister
@kennytmkennytm mentioned this pull request Mar 24, 2018
Merged
bors added a commit that referenced this pull request Mar 24, 2018
@bors
Auto merge of#49337- kennytm:rollup, r=kennytm
f5631d9
Rollup of 21 pull requests
- Successful merges: #49046, #49076, #49089, #49120, #49121, #49122, #49162, #49193, #49194, #49203, #49229, #49235, #49254, #49268, #49273, #49274, #49290, #49312, #49314, #49318, #49299
@bors
bors merged commit b1d872b into rust-lang:masterMar 24, 2018
@Zoxc
Zoxc deleted the error-summary branch March 24, 2018 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoeristermichaelwoerister

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Zoxc@bors@michaelwoerister@estebank@kennytm@rust-highfive