Uh oh!
There was an error while loading. Please reload this page.
Allow installing rustfmt without config.extended - #49290
Merged
Merged
Conversation
This assertion was preventing `./x.py install rustfmt` if attempted without an "extended" build configuration, but it actually builds and installs just fine.
rust-highfive
commented
Mar 23, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Mar 23, 2018
Contributor
@bors r+ cc @Mark-Simulacrum -- this seems fine but I thought I'd cc at least one other person who might know if there is some reason that assertion was there |
bors
commented
Mar 23, 2018
Collaborator
📌 Commit 86f7d89 has been approved by |
cuviper
commented
Mar 23, 2018
MemberAuthor
For contrast, the same assertion makes more sense on the But here, the |
Mark-Simulacrum
commented
Mar 23, 2018
Member
I think this is fine as well; we should probably cc @alexcrichton who wrote most of the dist code (AFAIK) though. |
alexcrichton
commented
Mar 23, 2018
Member
👍 |
alexcrichton
commented
Mar 23, 2018
Member
@bors: rollup |
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2018
…nikomatsakis Allow installing rustfmt without config.extended This assertion was preventing `./x.py install rustfmt` if attempted without an "extended" build configuration, but it actually builds and installs just fine.
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…nikomatsakis Allow installing rustfmt without config.extended This assertion was preventing `./x.py install rustfmt` if attempted without an "extended" build configuration, but it actually builds and installs just fine.
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…nikomatsakis Allow installing rustfmt without config.extended This assertion was preventing `./x.py install rustfmt` if attempted without an "extended" build configuration, but it actually builds and installs just fine.
bors added a commit
that referenced
this pull request
Mar 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assertion was preventing
./x.py install rustfmtif attemptedwithout an "extended" build configuration, but it actually builds and
installs just fine.