Skip to content

Rollup of 21 pull requests - #49325

Closed
kennytm wants to merge 70 commits into
rust-lang:masterfrom
kennytm:rollup
Closed

Rollup of 21 pull requests#49325
kennytm wants to merge 70 commits into
rust-lang:masterfrom
kennytm:rollup

Conversation

Maxwell Powlisonand others added 30 commits March 16, 2018 03:41
…l exclusion
The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and
`is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests
exclusively or not. It is now written that the tests are mutually exclusive.
Fixesrust-lang#48345.
This commit tweaks where timing and step information is printed out as part of
the build, ensuring that we do it as close to the location where work happens as
possible. In rustbuild various functions may perform long blocking work as
dependencies are assembled, so if we print out timing information early on we
may accidentally time more than just the step we were intending to time!
LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with.
For example, this makes `swap::<u64x8>` be 8x `vmovaps	ymm` instead of 16x `vmovups	xmm`, on my cpu.
This stabilizes `main` with non-() return types; see rust-lang#48453.
This removes 10 dependencies from the build 🎉
…lexcrichton
Remove getopts leftover from tree
This was attempted but left incomplete in PR rust-lang#42664, where only the toml
file was removed.
cc @alexcrichton
…, r=nikomatsakis
Stabilize termination_trait, split out termination_trait_test
For rust-lang#48453.
First time contribution, so I'd really appreciate any feedback on how this PR can be better.
Not sure exactly what kind of documentation update is needed. If there is no PR to update the reference, I can try doing that this week as I have time.
…docfix, r=bluss
Fix Issue rust-lang#48345, is_file, is_dir, and is_symlink note mutual exclusion
The methods on the structures `fs::FileType` and `fs::Metadata` of (respectively) `is_file`, `is_dir`, and `is_symlink` had some ambiguity in documentation, where it was not noted whether files will pass those tests exclusively or not. It is now written that the tests are mutually exclusive.
Fixesrust-lang#48345.
Make resuming generators unsafe instead of the creation of immovable generators
Fixesrust-lang#47787
@kennytmkennytm changed the title Rollup of 15 pull requestsRollup of 16 pull requestsMar 24, 2018
@kennytm

Copy link
Copy Markdown
MemberAuthor

@bors r+

Removed #49101 (tidy failed), #49203 (merge conflict)
Added #49162, #49076, #49194

@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 85abb05 has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
…ug, r=steveklabnik
Document format_args! / Arguments<'a> behavior wrt. Display and Debug
This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.
@kennytmkennytm changed the title Rollup of 16 pull requestsRollup of 17 pull requestsMar 24, 2018
@kennytm

kennytm commented Mar 24, 2018

Copy link
Copy Markdown
MemberAuthor

@bors r+

Added #49229, #49046

@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 175595a has been approved by kennytm

Always print `aborting due to n previous error(s)`
@kennytmkennytm changed the title Rollup of 17 pull requestsRollup of 18 pull requestsMar 24, 2018
@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 0acfcb8 has been approved by kennytm

…atsakis
Stabilize impl Trait
Blocked on:
- [x] rust-lang#49041 and
- [ ] completion of FCP in rust-lang#34511 (comment) (3 days from now).
I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).
Stabilize the copy_closures and clone_closures features
In addition to the `Fn*` family of traits, closures now implement `Copy` (and similarly `Clone`) if all of the captures do.
Tracking issue: rust-lang#44490
… r=Mark-Simulacrum
Bump racer and home
This removes 10 dependencies from the build 🎉
@kennytmkennytm changed the title Rollup of 18 pull requestsRollup of 21 pull requestsMar 24, 2018
@kennytm

Copy link
Copy Markdown
MemberAuthor

@bors r+

Added #49255, #49299, #49203

I've got meld fixed ☺️

@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f34d4f6 has been approved by kennytm

@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #49251) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2018
@kennytm

Copy link
Copy Markdown
MemberAuthor

Will create a new one.

@kennytmkennytm closed this Mar 24, 2018
@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@kennytm@bors@Centril@Zoxc@alexcrichton@varkor@scottmcm@tmandry@Eijebong@topecongiro@davidtwco@Tacklebox@cramertj@michaelwoerister@oli-obk@cuviper@SimonSapin@GuillaumeGomez@Mark-Simulacrum@ordovicia