Skip to content

Document format_args! / Arguments<'a> behavior wrt. Display and Debug - #49229

Merged
bors merged 3 commits into
rust-lang:masterfrom
Centril:doc/format_args_display_debug
Mar 24, 2018
Merged

Document format_args! / Arguments<'a> behavior wrt. Display and Debug#49229
bors merged 3 commits into
rust-lang:masterfrom
Centril:doc/format_args_display_debug

Conversation

@Centril

Copy link
Copy Markdown
Contributor

This is a follow up PR to #49067 , this documents the behavior of format_args! (i.e: Argument<'a>) wrt. Display and Debug.

r? @steveklabnik

@CentrilCentril added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Mar 21, 2018
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2018
@CentrilCentril added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 21, 2018

@steveklabniksteveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me, thanks! travis is failing due to the trailing whitespace though. r=me once it's green

Comment threadsrc/libcore/fmt/mod.rs Outdated
///
/// struct Arm<'a, L: 'a, R: 'a>(&'a (L, R));
/// struct Table<'a, K: 'a, V: 'a>(&'a [(K, V)], V);
///

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've got trailing whitespace here

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How embarrassing; should have run tidy ^,- I'll fix this sometime tonight =)

@Centril

Copy link
Copy Markdown
ContributorAuthor

r=@steveklabnik

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Mar 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 613fb8b has been approved by steveklabnik

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
…ug, r=steveklabnik
Document format_args! / Arguments<'a> behavior wrt. Display and Debug
This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.
@kennytmkennytm mentioned this pull request Mar 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
…ug, r=steveklabnik
Document format_args! / Arguments<'a> behavior wrt. Display and Debug
This is a follow up PR to rust-lang#49067 , this documents the behavior of `format_args!` (i.e: `Argument<'a>`) wrt. `Display` and `Debug`.
r? @steveklabnik
@kennytmkennytm mentioned this pull request Mar 24, 2018
bors added a commit that referenced this pull request Mar 24, 2018
@bors
bors merged commit 613fb8b into rust-lang:masterMar 24, 2018
@Centril
Centril deleted the doc/format_args_display_debug branch March 24, 2018 21:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-enhancementCategory: An issue proposing an enhancement or a PR with one.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Centril@steveklabnik@bors@rust-highfive