Fix sub-variant doc display by GuillaumeGomez · Pull Request #55191 · rust-lang/rust

GuillaumeGomez · 2018-10-18T23:35:56Z

rust-highfive · 2018-10-19T00:48:20Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:48:00] .................................................................................................... 2200/4625
[00:48:04] ..............................i..................................................................... 2300/4625
[00:48:07] .................................................................................................... 2400/4625
[00:48:11] .................................................................................................... 2500/4625
[00:48:14] ............................................iiiiiiiii............................................... 2600/4625
[00:48:21] .................................................................................................... 2800/4625
[00:48:24] .................................................................................................... 2900/4625
[00:48:27] ........................................................................i........................... 3000/4625
[00:48:30] .................................................................................................... 3100/4625
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:00:55] [01:00:55] running 111 tests
[01:00:58] i..ii...iii.......i...i.........i..iii...........i.....i.....ii...i.i.ii..............i...ii..ii..i. 100/111
[01:00:58] ..iiii.....
[01:00:58] [01:00:58] finished in 3.380
[01:00:58] travis_fold:end:test_codegen
---
[01:07:19] [01:07:19] running 268 tests
[01:08:21] .......................i............................................................................ 100/268
[01:09:14] ..............................i..................................................................... 200/268
[01:09:46] .....................................F..............................
[01:09:46] [01:09:46] ---- [rustdoc] rustdoc/structfields.rs stdout ----
[01:09:46] [01:09:46] [01:09:46] error: htmldocck failed!
[01:09:46] status: exit code: 1
[01:09:46] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/structfields" "/checkout/src/test/rustdoc/structfields.rs"
[01:09:46] ------------------------------------------
[01:09:46] [01:09:46] ------------------------------------------
[01:09:46] stderr:
[01:09:46] stderr:
[01:09:46] ------------------------------------------
[01:09:46] Traceback (most recent call last):
[01:09:46] File "/checkout/src/etc/htmldocck.py", line 461, in <module>
[01:09:46] check(sys.argv[1], get_commands(sys.argv[2]))
[01:09:46] File "/checkout/src/etc/htmldocck.py", line 454, in check
[01:09:46] check_command(c, cache)
[01:09:46] File "/checkout/src/etc/htmldocck.py", line 403, in check_command
[01:09:46] tree = cache.get_tree(c.args[0])
[01:09:46] File "/checkout/src/etc/htmldocck.py", line 311, in get_tree
[01:09:46] raise RuntimeError('Cannot parse an HTML file {!r}: {}'.format(path, e))
[01:09:46] RuntimeError: Cannot parse an HTML file 'structfields/enum.Qux.html': pop from empty stack
[01:09:46] ------------------------------------------
[01:09:46] [01:09:46] thread '[rustdoc] rustdoc/structfields.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[01:09:46] ---
[01:09:46] [01:09:46] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:503:22
[01:09:46] [01:09:46] [01:09:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:09:46] [01:09:46] [01:09:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:09:46] Build completed unsuccessfully in 0:26:19
[01:09:46] Build completed unsuccessfully in 0:26:19
[01:09:46] make: *** [check] Error 1
[01:09:46] Makefile:58: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:13788b46
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

QuietMisdreavus · 2018-10-21T21:42:52Z

cc @RalfJung

I'm building a local copy to check it out myself, but i'm curious what this looks like if one of these sub-fields has docs of its own, or an unstable banner, like in the original issue.

QuietMisdreavus · 2018-10-22T19:59:12Z

Personal testing with this branch:

/// that's some enum, all right#[unstable(feature="asdf", issue="0")]pubenumSomeEnum{Asdf,/// we got some variant here, i guessSomeVariant{/// it's one fieldone:usize,/// it's two fieldtwo:usize,},Qwop,Girp,}

The stability banners seem to overlap the field definitions?

Without the stability banners, it does look much better:

GuillaumeGomez · 2018-10-22T22:10:01Z

Good catch! I'll fix the stability banner *soon*.

RalfJung · 2018-10-23T07:31:40Z

It also looks odd to have to expand/collapse toggles here, one for the comment and one for the fields. Shouldn't that be just one?

Also, the horizontal line below "Fields of SomeVariant" extends too far to the left; makes it look like it encompasses also "Qwop" and "Girp".

GuillaumeGomez · 2018-10-23T21:13:15Z

Fixed.

@RalfJung I also moved the line more to the left.

RalfJung · 2018-10-23T21:20:41Z

To the right, you mean?

GuillaumeGomez · 2018-10-24T15:29:47Z

To the right indeed. 😆

QuietMisdreavus · 2018-10-24T19:51:50Z

Excellent, this looks much better!

RalfJung · 2018-10-24T19:54:42Z

It does. :)

I still don't understand why we have two expand/collapse trees below SomeVariant though? Makes it look somewhat cluttered, and it means one cannot use the [-] (which stand out visually quite nice) for visually navigating to the variants.

QuietMisdreavus · 2018-10-24T19:59:03Z

The first [-] collapses just the docs, the second collapses the sub-field listing.

However, you do bring up a good point - the section-marker that you can use to grab the anchor for the sub-fields is impossible to reach now. The marker appears all the way in the left gutter, and it goes away when you mouse over the space between the field name and the section marker.

GuillaumeGomez · 2018-10-24T20:12:12Z

Ah indeed. I'll fix it as well.

GuillaumeGomez · 2018-10-24T21:02:52Z

Fixed as well.

QuietMisdreavus · 2018-10-26T14:33:41Z

Much better, thanks!

@RalfJung Just to demonstrate the "two folds" thing, here's the same docs with a couple paragraphs of dummy text added. See how the extra text separates the two now:

There is something to be said about our habit of putting folding containers everywhere, but that discussion should probably happen elsewhere, maybe in its own issue or as a conversation on Discord or IRC first. For now, i think this PR is a good improvement for the problem it sets out to solve.

@bors r+

bors · 2018-10-26T14:33:42Z

📌 Commit 498ca085201ca356666660e865ec49d72ba690ea has been approved by QuietMisdreavus

bors · 2018-10-26T20:17:52Z

☔ The latest upstream changes (presumably #55382) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2018-10-27T19:46:51Z

@bors: r=QuietMisdreavus

bors · 2018-10-27T19:46:52Z

📌 Commit 2fd378b has been approved by QuietMisdreavus

bors · 2018-10-28T05:47:59Z

⌛ Testing commit 2fd378b with merge 89463a0598677a766fb74f57e0cbb4ca1e3b91c9...

bors · 2018-10-28T06:54:14Z

💔 Test failed - status-travis

rust-highfive · 2018-10-28T06:54:16Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:02:23] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[01:02:23] S=/checkout
[01:02:23] _=/bin/sh
[01:02:23] TOOLSTATE_REPO_ACCESS_TOKEN=[secure]
[01:02:23] TRAVIS=true
[01:02:23] RUST_RELEASE_CHANNEL=nightly
[01:02:23] PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[01:02:23] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[01:02:23] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[01:02:23] RUST_BUILD_STAGE=stage2-thumbv6m-none-eabi
[01:02:23] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[01:02:23] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make && python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[01:02:23] AR=ar
[01:02:23] TRAVIS_BRANCH=auto
[01:02:23] RUSTC_BOOTSTRAP=1
[01:02:23] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:02:23] SCCACHE_BUCKET=rust-lang-ci-sccache2
[01:02:23] PWD=/checkout/obj
[01:02:23] CI_JOB_NAME=dist-various-1
[01:02:23] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[01:02:23] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[01:02:23] PYTHON=/usr/bin/python2.7
[01:02:23] HOME=/home/user
[01:02:23] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[01:02:23] HOSTNAME=b648962c3e9e
[01:02:23] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[01:02:23] SHLVL=2
[01:02:23] CC= [01:02:23] BUILD_DIR=/checkout/obj/build
[01:02:23] BUILD_DIR=/checkout/obj/build
[01:02:23] RUST_TEST_TMPDIR=/checkout/obj/build/tmp
[01:02:23] LLVM_CXXFLAGS=
[01:02:23] RUSTFLAGS=--cap-lints=allow
[01:02:23] STAGING_DIR=/tmp
[01:02:23] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[01:02:23] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[01:02:23] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te --musl-root-arm=/musl-arm --musl-root-armhf=/musl-armhf --musl-root-armv7=/musl-armv7 --musl-root-aarch64=/musl-aarch64 --musl-root-mips=/musl-mips --musl-root-mipsel=/musl-mipsel --enable-emscripten --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[01:02:23] MAKEFLAGS=
[01:02:23] MFLAGS=
[01:02:23] BOOTSTRAP_PARENT_ID=1052
[01:02:23] BOOTSTRAP_PARENT_ID=1052
[01:02:23] __COMPAT_LAYER=RunAsInvoker
[01:02:23] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[01:02:23] BUILD=x86_64-unknown-linux-gnu
[01:02:23] CXX= [01:02:23] AWS_ACCESS_KEY_ID=AKIAJAMV3QAMMA6AXHFQ
[01:02:23] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[01:02:23] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[01:02:23] CARGO_HOME=/cargo
[01:02:23] RUSTC_LINKER=arm-none-eabi-gcc
[01:02:23] SCCACHE_REGION=us-west-1
[01:02:23] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[01:02:23] LLVM_COMPONENTS=
[01:02:23] TERM=xterm
[01:02:23] MAKELEVEL=1
[01:02:23] mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[01:02:23] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && rm -rf cortex-m
[01:02:23] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && bash -x /checkout/src/test/run-make/thumb-none-cortex-m/../git_clone_sha1.sh cortex-m https://github.com/rust-embedded/cortex-m a448e9156e2cb1e556e5441fd65426952ef4b927 [01:02:23] Makefile:31: recipe for target 'all' failed
[01:02:23] [01:02:23] ------------------------------------------
[01:02:23] stderr:
[01:02:23] stderr:
[01:02:23] ------------------------------------------
[01:02:23] + PROJECT_NAME=cortex-m
[01:02:23] + URL=https://github.com/rust-embedded/cortex-m
[01:02:23] + SHA1=a448e9156e2cb1e556e5441fd65426952ef4b927
[01:02:23] + git clone https://github.com/rust-embedded/cortex-m cortex-m
[01:02:23] Cloning into 'cortex-m'...
[01:02:23] fatal: unable to access 'https://github.com/rust-embedded/cortex-m/': Could not resolve host: github.com
[01:02:23] + err_exit
[01:02:23] + echo ERROR:
[01:02:23] + exit 1
[01:02:23] make: *** [all] Error 1
[01:02:23] ------------------------------------------
[01:02:23] [01:02:23] thread '[run-make] run-make/thumb-none-cortex-m' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3284:9
[01:02:23] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[01:02:23] test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:02:23] [01:02:23] [01:02:23] [01:02:23] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:02:23] [01:02:23] [01:02:23] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
[01:02:23] Build completed unsuccessfully in 0:58:00
---
travis_time:end:06d96804:start=1540709529130983319,finish=1540709529143199216,duration=12215897
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00d5e4d6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:000331ef
travis_time:start:000331ef
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09c47911
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-10-28T07:08:33Z

@bors retry travis-ci/travis-ci#9696

@QuietMisdreavus

…uietMisdreavus Fix sub-variant doc display Fixesrust-lang#54758. <img width="1440" alt="screen shot 2018-10-19 at 01 34 11" src="https://user-images.githubusercontent.com/3050060/47189939-43481d00-d33f-11e8-868f-cf479fc79e62.png"> r? @QuietMisdreavus

Rollup of 11 pull requests Successful merges: - #55148 (Implement FromStr for PathBuf) - #55185 (path suggestions in Rust 2018 should point out the change in semantics) - #55191 (Fix sub-variant doc display) - #55199 (Impl items have generics) - #55244 (Don't rerun MIR passes when inlining) - #55252 (Add MaybeUninit::new) - #55257 (Allow extern statics with an extern type) - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…) - #55406 (Update string.rs) - #55412 (Fix an ICE in the min_const_fn analysis) - #55421 (Add ManuallyDrop::take)

rust-highfive assigned QuietMisdreavus Oct 18, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2018

GuillaumeGomez force-pushed the fix-sub-variant branch from 8bc8e63 to 9b1e34aCompare October 20, 2018 21:47

GuillaumeGomez force-pushed the fix-sub-variant branch 2 times, most recently from c8b009e to 4d4aacbCompare October 23, 2018 21:12

GuillaumeGomez force-pushed the fix-sub-variant branch from 4d4aacb to 498ca08Compare October 24, 2018 20:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2018

Fix sub-variant doc display
2fd378b

GuillaumeGomez force-pushed the fix-sub-variant branch from 498ca08 to 2fd378bCompare October 27, 2018 12:05

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2018

kennytm mentioned this pull request Oct 28, 2018
Rollup of 11 pull requests #55433
Merged

bors merged commit 2fd378b into rust-lang:masterOct 28, 2018

GuillaumeGomez deleted the fix-sub-variant branch October 28, 2018 23:46

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Oct 18, 2018

Uh oh!

rust-highfive commented Oct 19, 2018

Uh oh!

QuietMisdreavus commented Oct 21, 2018

Uh oh!

QuietMisdreavus commented Oct 22, 2018

Uh oh!

GuillaumeGomez commented Oct 22, 2018

Uh oh!

RalfJung commented Oct 23, 2018

Uh oh!

GuillaumeGomez commented Oct 23, 2018

Uh oh!

RalfJung commented Oct 23, 2018

Uh oh!

GuillaumeGomez commented Oct 24, 2018

Uh oh!

QuietMisdreavus commented Oct 24, 2018

Uh oh!

RalfJung commented Oct 24, 2018

Uh oh!

QuietMisdreavus commented Oct 24, 2018

Uh oh!

GuillaumeGomez commented Oct 24, 2018

Uh oh!

GuillaumeGomez commented Oct 24, 2018

Uh oh!

QuietMisdreavus commented Oct 26, 2018

Uh oh!

bors commented Oct 26, 2018

Uh oh!

bors commented Oct 26, 2018

Uh oh!

GuillaumeGomez commented Oct 27, 2018

Uh oh!

bors commented Oct 27, 2018

Uh oh!

bors commented Oct 28, 2018

Uh oh!

bors commented Oct 28, 2018

Uh oh!

rust-highfive commented Oct 28, 2018

Uh oh!

kennytm commented Oct 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants