Uh oh!
There was an error while loading. Please reload this page.
Fix an ICE in the min_const_fn analysis - #55412
Merged
Merged
Conversation
rust-highfive
commented
Oct 27, 2018
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
Centril
approved these changes
Oct 27, 2018
Centril
commented
Oct 27, 2018
Contributor
Tests look good; that's about it wrt. what I can comment on :) |
estebank
commented
Oct 27, 2018
Contributor
@bors r+ rollup |
bors
commented
Oct 27, 2018
Collaborator
📌 Commit c04893a has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 27, 2018
Fix an ICE in the min_const_fn analysis fixesrust-lang#55395 cc @Centril
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 28, 2018
Fix an ICE in the min_const_fn analysis fixesrust-lang#55395 cc @Centril
bors added a commit
that referenced
this pull request
Oct 28, 2018
Rollup of 11 pull requests Successful merges: - #55148 (Implement FromStr for PathBuf) - #55185 (path suggestions in Rust 2018 should point out the change in semantics) - #55191 (Fix sub-variant doc display) - #55199 (Impl items have generics) - #55244 (Don't rerun MIR passes when inlining) - #55252 (Add MaybeUninit::new) - #55257 (Allow extern statics with an extern type) - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…) - #55406 (Update string.rs) - #55412 (Fix an ICE in the min_const_fn analysis) - #55421 (Add ManuallyDrop::take)
oli-obk
commented
Oct 29, 2018
ContributorAuthor
Nominating for beta, as otherwise we'd have an ICE instead of an error in the first stable that has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#55395
cc @Centril