Skip to content

Impl items have generics - #55199

Merged
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:instance_printing
Oct 28, 2018
Merged

Impl items have generics#55199
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:instance_printing

Conversation

@oli-obk

@oli-obkoli-obk commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-langrust-lang deleted a comment from rust-highfiveOct 20, 2018
@rust-langrust-lang deleted a comment from rust-highfiveOct 20, 2018
@davidtwco

This comment has been minimized.

Sign in to view
1 similar comment
@davidtwco

davidtwco commented Oct 23, 2018

Copy link
Copy Markdown
Member

@bors r+

@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018
bjorn3
bjorn3 requested changes Oct 24, 2018
View reviewed changes
Comment threadsrc/librustc_mir/const_eval.rs Outdated

@bjorn3bjorn3Oct 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why trace both key and key.value.instance?

@oli-obkoli-obkOct 24, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the printing via Display of the instance goes through the code that was ICEing here before

@bjorn3bjorn3Oct 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it

@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2018
@RalfJung

RalfJung commented Oct 26, 2018

Copy link
Copy Markdown
Member

You just rebased, right? So we can r=davidtwco again?

Cc @davidtwco

@davidtwco

davidtwco commented Oct 26, 2018

Copy link
Copy Markdown
Member

Thanks @RalfJung. Wish GitHub would email on pushes.

@bors r+

@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2018
@oli-obk

oli-obk commented Oct 26, 2018

Copy link
Copy Markdown
ContributorAuthor

rebased again, and added a comment about what's going on

@davidtwco

davidtwco commented Oct 26, 2018

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 5a48f20 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018
@bors

bors commented Oct 28, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5a48f20 with merge 432e9f370d86b3212d1a153c263c946e979d9314...

@bors

bors commented Oct 28, 2018

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2018
@davidtwco

davidtwco commented Oct 28, 2018

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018
@kennytm
Rollup merge ofrust-lang#55199- oli-obk:instance_printing, r=davidtwco
db4e77c
Impl items have generics
@kennytmkennytm mentioned this pull request Oct 28, 2018
Merged
bors added a commit that referenced this pull request Oct 28, 2018
@bors
Auto merge of#55433- kennytm:rollup, r=kennytm
d492c67
Rollup of 11 pull requests
Successful merges:
- #55148 (Implement FromStr for PathBuf)
- #55185 (path suggestions in Rust 2018 should point out the change in semantics)
- #55191 (Fix sub-variant doc display)
- #55199 (Impl items have generics)
- #55244 (Don't rerun MIR passes when inlining)
- #55252 (Add MaybeUninit::new)
- #55257 (Allow extern statics with an extern type)
- #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
- #55406 (Update string.rs)
- #55412 (Fix an ICE in the min_const_fn analysis)
- #55421 (Add ManuallyDrop::take)
@bors
bors merged commit 5a48f20 into rust-lang:masterOct 28, 2018
@RalfJungRalfJung mentioned this pull request Oct 29, 2018
Closed
@oli-obk
oli-obk deleted the instance_printing branch June 15, 2020 15:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3bjorn3bjorn3 requested changes

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk@rust-highfive@davidtwco@bors@RalfJung@bjorn3