Add long error explanation for E0493 by GuillaumeGomez · Pull Request #64377 · rust-lang/rust

GuillaumeGomez · 2019-09-11T11:51:30Z

Part of #61137.

rust-highfive · 2019-09-11T11:51:33Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rust-highfive · 2019-09-11T11:51:34Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-09-11T12:04:13Z

I'm not sure we should (only?) suggest lazy_static here. It feels like playing favorites while crates like https://docs.rs/once_cell/1.1.0/once_cell/ might be more idiomatic Rust these days.

Maybe I should just not talk about those crate at all. I'll remove this part.

estebank · 2019-09-12T17:38:16Z

@bors r+ rollup

bors · 2019-09-12T17:38:17Z

📌 Commit 0ad141c has been approved by estebank

Add long error explanation for E0493 Part of rust-lang#61137.

Centril · 2019-09-13T15:47:55Z

Failed in #64427 (comment), @bors r-

Please run --compare-mode=nll.

Mark-Simulacrum · 2019-09-16T23:41:54Z

Awkwardly stealing this PR for some initial testing...

@rust-timer queue

rust-timer · 2019-09-16T23:41:56Z

Successfully queued build, kicking off bors: @bors try

bors · 2019-09-16T23:41:57Z

@rust-timer: 🔑 Insufficient privileges: not in try users

Alexendoo · 2019-09-25T17:21:53Z

Ping from triage, any updates? @GuillaumeGomez

Centril · 2019-09-29T17:34:20Z

@GuillaumeGomez updates? // triage

GuillaumeGomez · 2019-09-30T11:47:25Z

Updated!

estebank · 2019-09-30T20:27:45Z

@bors r+

bors · 2019-09-30T20:27:47Z

📌 Commit 9f978b7 has been approved by estebank

Add long error explanation for E0493 Part of rust-lang#61137.

@ghost

Rollup of 9 pull requests Successful merges: - #64377 (Add long error explanation for E0493) - #64786 (Use https for curl when building for linux) - #64828 (Graphviz debug output for generic dataflow analysis) - #64838 (Add long error explanation for E0550) - #64891 (Fix `vec![x; n]` with null raw fat pointer zeroing the pointer metadata) - #64893 (Zero-initialize `vec![None; n]` for `Option<&T>`, `Option<&mut T>` and `Option<Box<T>>`) - #64911 (Fixed a misleading documentation issue #64844) - #64921 (Add test for issue-64662) - #64923 (Add missing links for mem::needs_drop) Failed merges: - #64918 (Add long error explanation for E0551) r? @ghost

rust-highfive assigned estebank Sep 11, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2019

GuillaumeGomez mentioned this pull request Sep 11, 2019
Add missing long error code explanations #61137
Closed
100 tasks

Centril reviewed Sep 11, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

GuillaumeGomez force-pushed the E0493 branch from e375c16 to 9ac9c04Compare September 12, 2019 07:59

This comment has been minimized.
Sign in to view

GuillaumeGomez force-pushed the E0493 branch from 9ac9c04 to 0ad141cCompare September 12, 2019 13:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2019

Centril added a commit to Centril/rust that referenced this pull request Sep 13, 2019
Rollup merge ofrust-lang#64377- GuillaumeGomez:E0493, r=estebank
1059ddd
Add long error explanation for E0493 Part of rust-lang#61137.

Centril mentioned this pull request Sep 13, 2019
Rollup of 9 pull requests #64427
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2019

Centril reviewed Sep 13, 2019
View reviewed changes

Comment threadsrc/librustc_mir/error_codes.rs Outdated

GuillaumeGomez added 2 commits September 30, 2019 13:47

Add long error explanation for E0493
cc9db52

update tests
9f978b7

GuillaumeGomez force-pushed the E0493 branch from 0ad141c to 9f978b7Compare September 30, 2019 11:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2019

tmandry added a commit to tmandry/rust that referenced this pull request Sep 30, 2019
Rollup merge ofrust-lang#64377- GuillaumeGomez:E0493, r=estebank
30ba6fd
Add long error explanation for E0493 Part of rust-lang#61137.

tmandry mentioned this pull request Sep 30, 2019
Rollup of 9 pull requests #64932
Merged

bors merged commit 9f978b7 into rust-lang:masterOct 1, 2019

GuillaumeGomez deleted the E0493 branch October 1, 2019 09:47

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Sep 11, 2019

Uh oh!

rust-highfive commented Sep 11, 2019

Uh oh!

rust-highfive commented Sep 11, 2019

Uh oh!

Uh oh!

Uh oh!

CentrilSep 11, 2019

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezSep 12, 2019

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

estebank commented Sep 12, 2019

Uh oh!

bors commented Sep 12, 2019

Uh oh!

Centril commented Sep 13, 2019

Uh oh!

Uh oh!

Mark-Simulacrum commented Sep 16, 2019

Uh oh!

rust-timer commented Sep 16, 2019

Uh oh!

bors commented Sep 16, 2019

Uh oh!

Alexendoo commented Sep 25, 2019

Uh oh!

Centril commented Sep 29, 2019

Uh oh!

GuillaumeGomez commented Sep 30, 2019

Uh oh!

estebank commented Sep 30, 2019

Uh oh!

bors commented Sep 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants