Uh oh!
There was an error while loading. Please reload this page.
Use https for curl when building for linux - #64786
Conversation
Mark-Simulacrum
commented
Sep 25, 2019
I'm impressed by the curl sites reliability that we haven't yet replaced it with our own aws tarballs... @bors r+ rollup |
bors
commented
Sep 25, 2019
📌 Commit 9bd201c has been approved by |
Use https for curl when building for linux I noticed that the dist-x86_64-linux builder uses http to fetch curl and doesn't do any signature verification. It should probably use https. r? @alexcrichton@Mark-Simulacrum
Centril
commented
Sep 26, 2019
Failed in #64791 (comment), @bors r- |
Mark-Simulacrum
commented
Sep 26, 2019
Very interesting. I now seem to recall something like this. We can probably just mirror it on one our own bucket, I'll look into doing that today. |
| VERSION=7.51.0 | ||
| curl http://cool.haxx.se/download/curl-$VERSION.tar.bz2 | tar xjf - | ||
| curl https://cool.haxx.se/download/curl-$VERSION.tar.bz2 | tar xjf - |
There was a problem hiding this comment.
| curl https://cool.haxx.se/download/curl-$VERSION.tar.bz2| tar xjf - | |
| curl https://rust-lang-ci-mirrors.s3-us-west-1.amazonaws.com/rustc/curl-7.66.0.tar.xz| tar xJf - |
Should probably update the version to match as well and use that (I assume it's used at some later point in the build).
alexcrichton
commented
Sep 26, 2019
I don't believe this will work because we need an http client that supports sni, and basically all modern servers require sni, including s3 most likely. I don't believe the pre installed curl on centos supports sni |
Mark-Simulacrum
commented
Sep 26, 2019
Ah, I see. That's a bit unfortunate. So I guess that's probably why the https wasn't working either... I suppose we could get the curl in a ubuntu docker image and then switch to centos, but that seems really complicated. |
alexcrichton
commented
Sep 26, 2019
That being said, looks like AWS does not require SNI. We download OpenSSL through our s3 bucket, so seems like downloading curl through the bucket is worth a try! |
tmandry
commented
Sep 28, 2019
@bors try |
bors
commented
Sep 28, 2019
⌛ Trying commit ff43ab7d5d1d52bc912582e04da065cd093380e4 with merge 18c62604adbfd5cb003feb46a424712a4af6e98c... |
rust-highfive
commented
Sep 28, 2019
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Sep 28, 2019
💔 Test failed - checks-azure |
tmandry
commented
Sep 28, 2019
Unfortunately I can't test this locally (centos 5 and 6 images use outdated vsyscall which is unsupported on my kernel), so I'm flying blind... |
bors
commented
Sep 28, 2019
bors
commented
Sep 29, 2019
💥 Test timed out |
tmandry
commented
Sep 29, 2019
@bors try |
bors
commented
Sep 29, 2019
Use https for curl when building for linux I noticed that the dist-x86_64-linux builder uses http to fetch curl and doesn't do any signature verification. It should probably use https. r? @alexcrichton@Mark-Simulacrum
bors
commented
Sep 30, 2019
💥 Test timed out |
alexcrichton
commented
Sep 30, 2019
@bors: r+ Looks like it worked, just timed out! |
bors
commented
Sep 30, 2019
📌 Commit 2185710 has been approved by |
Use https for curl when building for linux I noticed that the dist-x86_64-linux builder uses http to fetch curl and doesn't do any signature verification. It should probably use https. r? @alexcrichton@Mark-Simulacrum
Use https for curl when building for linux I noticed that the dist-x86_64-linux builder uses http to fetch curl and doesn't do any signature verification. It should probably use https. r? @alexcrichton@Mark-Simulacrum
Rollup of 9 pull requests Successful merges: - #64377 (Add long error explanation for E0493) - #64786 (Use https for curl when building for linux) - #64828 (Graphviz debug output for generic dataflow analysis) - #64838 (Add long error explanation for E0550) - #64891 (Fix `vec![x; n]` with null raw fat pointer zeroing the pointer metadata) - #64893 (Zero-initialize `vec![None; n]` for `Option<&T>`, `Option<&mut T>` and `Option<Box<T>>`) - #64911 (Fixed a misleading documentation issue #64844) - #64921 (Add test for issue-64662) - #64923 (Add missing links for mem::needs_drop) Failed merges: - #64918 (Add long error explanation for E0551) r? @ghost
tmandry
commented
Oct 2, 2019
[BETA] Backport changes - update rtpSpawn's parameters type(It's prototype has been updated in libc) rust-lang#64818 - Fix div_duration() marked as stable by mistake rust-lang#64815 - Use https for curl when building for linux rust-lang#64786 - remove rtp.rs, and move rtpSpawn and RTP_ID_ERROR to libc rust-lang#64720 r? @ghost
I noticed that the dist-x86_64-linux builder uses http to fetch curl and doesn't do any signature verification. It should probably use https.
r? @alexcrichton@Mark-Simulacrum