Skip to content

Add long error explanation for E0550 - #64838

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:long-err-explanation-e0550
Oct 1, 2019
Merged

Add long error explanation for E0550#64838
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:long-err-explanation-e0550

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Part of #61137

@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2019
Comment threadsrc/libsyntax/error_codes.rs Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[deprecated(note = "because why not?")]
#[deprecated(note = "because why not, right?")]

maybe something like this would suggest merging the two attributes into one

Comment threadsrc/libsyntax/error_codes.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
More than one `deprecated` attribute have been put on an item.
More than one `deprecated` attribute has been put on an item.

@oli-obkoli-obk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nits resolved

@oli-obk

Copy link
Copy Markdown
Contributor

r? @oli-obk

@rust-highfiverust-highfive assigned oli-obk and unassigned eddybSep 28, 2019
@oli-obkoli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2019
@GuillaumeGomez
GuillaumeGomezforce-pushed the long-err-explanation-e0550 branch from 4733f29 to e67ae0eCompareSeptember 30, 2019 13:53
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

Nits resolved, tests passed.

@bors: r=oli-obk

@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit e67ae0e has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2019
@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e67ae0e with merge d78d6188048f40cd938e70990a85395777708698...

tmandry added a commit to tmandry/rust that referenced this pull request Sep 30, 2019
…-e0550, r=oli-obk
Add long error explanation for E0550
Part of rust-lang#61137
@tmandrytmandry mentioned this pull request Sep 30, 2019
@tmandry

Copy link
Copy Markdown
Member

@bors retry rolled up

tmandry added a commit to tmandry/rust that referenced this pull request Sep 30, 2019
…-e0550, r=oli-obk
Add long error explanation for E0550
Part of rust-lang#61137
@tmandrytmandry mentioned this pull request Sep 30, 2019
bors added a commit that referenced this pull request Oct 1, 2019
Rollup of 9 pull requests
Successful merges:
- #64377 (Add long error explanation for E0493)
- #64786 (Use https for curl when building for linux)
- #64828 (Graphviz debug output for generic dataflow analysis)
- #64838 (Add long error explanation for E0550)
- #64891 (Fix `vec![x; n]` with null raw fat pointer zeroing the pointer metadata)
- #64893 (Zero-initialize `vec![None; n]` for `Option<&T>`, `Option<&mut T>` and `Option<Box<T>>`)
- #64911 (Fixed a misleading documentation issue #64844)
- #64921 (Add test for issue-64662)
- #64923 (Add missing links for mem::needs_drop)
Failed merges:
- #64918 (Add long error explanation for E0551)
r? @ghost
@bors
bors merged commit e67ae0e into rust-lang:masterOct 1, 2019
@GuillaumeGomez
GuillaumeGomez deleted the long-err-explanation-e0550 branch October 1, 2019 09:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-highfive@oli-obk@bors@tmandry@eddyb