Graphviz debug output for generic dataflow analysis

[ecstatic-morse]

A follow up to #64566.

This outputs graphviz diagrams in the generic dataflow engine when #[rustc_mir(borrowck_graphviz_postflow="suffix.dot")] is set on an item. This code is based on dataflow/graphviz.rs, but displays different information since there are no "gen"/"kill" sets and transfer functions cannot be coalesced in the generic analysis. As a result, we show the dataflow state at the start and end of each block, as well as the changes resulting from each statement. I also render the state bitset in full ({_1,_2}) instead of hex-encoded as the current renderer does (06).

[rust-highfive]

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

[ecstatic-morse]

r? @oli-obk

[ecstatic-morse]

Oh, this should only get merged after #64470 does, since this changes the signature of dataflow::generic::Engine::new.

[eddyb]

I think it would be neat to use debug_set for more things, including all of our set abstractions, and this.

Instead of (_1,_2), you'd get {_1, _2} which looks more like a set to me, at least.

[ecstatic-morse]

The only reason I didn't go with debug_set was to get rid of the space after the comma. I'm considering changing to the hex representation (14-ef) when the cardinality crosses a certain threshold, which would make this less of an issue. I also thought about printing the full set on entry and exit but only printing the diff for each statement, but this is kind of a pain if you want to know the state in the middle of a longer basic block.

[ecstatic-morse]

I switched to only rendering the diff for each statement but printing the full dataset at block entry and exit. This makes it a lot easier to track changes to the dataflow state when there are a lot of elements, but makes it more difficult to quickly see the whole state at a given statement. I also improved the formatting a bit. Here's the new on the same input file:

This particular analysis never clears dataflow bits, but those would appear in red prefixed with a minus.

[bors]

☔ The latest upstream changes (presumably #64778) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

just some nits

[ecstatic-morse]

I've fixed merge conflicts and cleaned up the code a bit. I also added an extra row to the table for each basic block, so that both the diff for the terminator and the full state after the terminator's transfer function is applied are displayed. I think this is ready to go.

#![feature(rustc_attrs)]#![feature(const_if_match)]#[rustc_mir(borrowck_graphviz_postflow="test.dot")]const _:Option<&std::cell::Cell<i32>> = iffalse{Some(&std::cell::Cell::new(5))}else{None};

Old table:

New table:

[oli-obk]

@bors r+

[bors]

📌 Commit 2b8e023 has been approved by oli-obk