Skip to content

Fix typo - #3555

Merged
flying-sheep merged 4 commits into
scverse:mainfrom
swstkm:fix_paga_paul15_tut
May 8, 2025
Merged

Fix typo#3555
flying-sheep merged 4 commits into
scverse:mainfrom
swstkm:fix_paga_paul15_tut

Conversation

@swstkm

@swstkm swstkm commented Apr 2, 2025

Copy link
Copy Markdown
Contributor
  • Closes N/A
  • Tests included or not required because: minor documentation issue
  • Release notes not necessary because: minor documentation issue

@swstkm
swstkm marked this pull request as draft April 2, 2025 15:25
@swstkm
swstkm marked this pull request as ready for review April 2, 2025 15:29
@swstkm

swstkm commented Apr 2, 2025

Copy link
Copy Markdown
Contributor Author

It seems like the failed checks are because of notebooks/ being from scanpy-tutorials submodule to which I made the original changes. Should I be making changes to that repo specifically and close this PR or is there a way to combine these changes from scanpy repo itself?

@Zethson Zethson self-assigned this Apr 11, 2025
@Zethson

Zethson commented Apr 11, 2025

Copy link
Copy Markdown
Member

Sorry for the late response.

The way to go is:

  1. Make the changes in the submodule and make a PR for the submodule.
  2. Make a PR here with the updated submodule to demonstrate that updating the submodule doesn't break things.
  3. When we think that this PR is ready, we merge the PR at the submodule first.
  4. Next, you update the submodule hash here again because it might've changed when we merged it. It should point to the hash of the merged state and not a non-existent PR hash.
  5. Finally, we can merge this PR.

Does this help?

@swstkm

swstkm commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

@Zethson sounds like a rather complicated way to get a basic link fixed. I'm leaning towards closing the PR and you can do the whole thing much more quickly maybe?

@Zethson

Zethson commented Apr 11, 2025

Copy link
Copy Markdown
Member

Yeah, I can do that. Suggestion: Please revert the submodule update and we can merge this PR with the typo fix. If there's no issue yet for the broken link, please create it and ping me. I'll assign myself to it.

@Zethson Zethson changed the title Fix link to preprocessing recipe of Zheng et al. 2017 and typo Fix typo Apr 11, 2025
@flying-sheep flying-sheep added this to the 1.11.2 milestone Apr 14, 2025
@flying-sheep
flying-sheep merged commit b058b17 into scverse:main May 8, 2025
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request May 8, 2025
flying-sheep pushed a commit that referenced this pull request May 8, 2025
Co-authored-by: Swastik Mishra <4453983+swstkm@users.noreply.github.com>
selmanozleyen pushed a commit that referenced this pull request May 19, 2025
Co-authored-by: Phil Schaf <flying-sheep@web.de>
ilan-gold added a commit that referenced this pull request May 19, 2025
* update normalize_total & remove dep

* refactor: `normalize_total` with Numba (#3593)

Co-authored-by: Philipp A. <flying-sheep@web.de>

* fix doctest

* add release note

* Switch from profimp to tuna for parsing import profiles (#3620)

* [pre-commit.ci] pre-commit autoupdate (#3622)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Philipp A. <flying-sheep@web.de>

* Fix typo (#3555)

Co-authored-by: Phil Schaf <flying-sheep@web.de>

* Switch to fast-array-utils (#3598)

Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>

* tSNE components parameter (#2803)

Co-authored-by: Phil Schaf <flying-sheep@web.de>

* Simplify scale (#3351)

Co-authored-by: Intron7 <severin.dicks@icloud.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove layers test

* explicit return and fix the info message

* remove unnecessary ravel's

* precision fix

* (fix): maintain data type properly.

* (fix): remove artifact storage

* (refactor): use nice f-a-u typing

---------

Co-authored-by: Philipp A. <flying-sheep@web.de>
Co-authored-by: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Swastik Mishra <4453983+swstkm@users.noreply.github.com>
Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>
Co-authored-by: Kitsune <48340051+ch1ru@users.noreply.github.com>
Co-authored-by: selmanozleyen <syozleyen@gmail.com>
Co-authored-by: ilan-gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants