Switch from profimp to tuna for parsing import profiles - #3620
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3620 +/- ##
=======================================
Coverage 75.67% 75.67%
=======================================
Files 114 114
Lines 13143 13143
=======================================
Hits 9946 9946
Misses 3197 3197 |
ilan-gold
approved these changes
May 5, 2025
ilan-gold
reviewed
May 5, 2025
| data = json.loads(proc.stdout) | ||
| return descend(data, set(modules), []) | ||
| with NamedTemporaryFile() as f: | ||
| Path(f.name).write_bytes(proc.stderr) |
Contributor
There was a problem hiding this comment.
why stderr here? just curious since it was stdout.
Member
Author
There was a problem hiding this comment.
Completely different thing happening here:
- profimp does ✨something✨ to create the profile and emits JSON on stdout
PYTHONPROFILEIMPORTTIME/-X importtimecauses Python itself to emit import profiling data on stderr in a text format
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
May 5, 2025
flying-sheep
added a commit
that referenced
this pull request
May 5, 2025
…files (#3621) Co-authored-by: Philipp A <flying-sheep@web.de>
selmanozleyen
pushed a commit
that referenced
this pull request
May 19, 2025
ilan-gold
added a commit
that referenced
this pull request
May 19, 2025
* update normalize_total & remove dep * refactor: `normalize_total` with Numba (#3593) Co-authored-by: Philipp A. <flying-sheep@web.de> * fix doctest * add release note * Switch from profimp to tuna for parsing import profiles (#3620) * [pre-commit.ci] pre-commit autoupdate (#3622) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Philipp A. <flying-sheep@web.de> * Fix typo (#3555) Co-authored-by: Phil Schaf <flying-sheep@web.de> * Switch to fast-array-utils (#3598) Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com> * tSNE components parameter (#2803) Co-authored-by: Phil Schaf <flying-sheep@web.de> * Simplify scale (#3351) Co-authored-by: Intron7 <severin.dicks@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * remove layers test * explicit return and fix the info message * remove unnecessary ravel's * precision fix * (fix): maintain data type properly. * (fix): remove artifact storage * (refactor): use nice f-a-u typing --------- Co-authored-by: Philipp A. <flying-sheep@web.de> Co-authored-by: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Swastik Mishra <4453983+swstkm@users.noreply.github.com> Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com> Co-authored-by: Kitsune <48340051+ch1ru@users.noreply.github.com> Co-authored-by: selmanozleyen <syozleyen@gmail.com> Co-authored-by: ilan-gold <ilanbassgold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profimp was last released in 2018, so I’m switching to native profiling (and
tunafor parsing) instead.