normalize_total with numba - #3571
Conversation
| for i in numba.prange(rows): | ||
| count = counts_per_cell[i] / target_sum | ||
| for j in range(indptr[i], indptr[i + 1]): | ||
| data[j] /= count | ||
| return counts_per_cell, target_sum, counts_per_cols |
There was a problem hiding this comment.
so this part can be in fast-array-utils under the name elem_mult @flying-sheep right? This is what I understood from our discussions. Should we first implement elem_mult then come back to this issue?
There was a problem hiding this comment.
Generally I wouldn’t stop scanpy improvements for fast_array_utils.
But if part of this can be replaced with a mult helper, we could do that now!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3571 +/- ##
==========================================
+ Coverage 76.68% 76.74% +0.05%
==========================================
Files 113 113
Lines 12709 12703 -6
==========================================
+ Hits 9746 9749 +3
+ Misses 2963 2954 -9
|
Co-authored-by: Philipp A. <flying-sheep@web.de>
|
@Intron7 you have to write |
|
Also this needs a release note! |
|
@flying-sheep of course |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Philipp A. <flying-sheep@web.de>
Co-authored-by: Phil Schaf <flying-sheep@web.de>
Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>
Co-authored-by: Phil Schaf <flying-sheep@web.de>
Co-authored-by: Intron7 <severin.dicks@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes #3135
This also removes the deprecated functions out