Switch to fast-array-utils - #3598
Merged
Merged
Conversation
flying-sheep
force-pushed
the
pa/fast-array-utils
branch
from
April 25, 2025 14:09
2845911 to
33b3a86
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
+ Coverage 75.67% 76.68% +1.01%
==========================================
Files 114 113 -1
Lines 13143 12735 -408
==========================================
- Hits 9946 9766 -180
+ Misses 3197 2969 -228
|
flying-sheep
marked this pull request as ready for review
May 8, 2025 10:42
ilan-gold
approved these changes
May 8, 2025
ilan-gold
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable. What is to come of testing i.e., using fast-array-utils's mechanisms for that? We will do this in anndata first?
Benchmark changes
Comparison: https://github.com/scverse/scanpy/compare/48fcaa980063f2cc25fc7b3a9703dcf1926686b1..0a407afa3232eaee2916dad2d5163df656b87180 More details: https://github.com/scverse/scanpy/pull/3598/checks?check_run_id=42051919522 |
Member
Author
yeah, I think we should do it in anndata first!
this is the only slightly concerning benchmark, I think I’ll look into that before merging /edit: can’t reproduce locally |
flying-sheep
added a commit
that referenced
this pull request
May 12, 2025
selmanozleyen
pushed a commit
that referenced
this pull request
May 19, 2025
Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>
ilan-gold
added a commit
that referenced
this pull request
May 19, 2025
* update normalize_total & remove dep * refactor: `normalize_total` with Numba (#3593) Co-authored-by: Philipp A. <flying-sheep@web.de> * fix doctest * add release note * Switch from profimp to tuna for parsing import profiles (#3620) * [pre-commit.ci] pre-commit autoupdate (#3622) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Philipp A. <flying-sheep@web.de> * Fix typo (#3555) Co-authored-by: Phil Schaf <flying-sheep@web.de> * Switch to fast-array-utils (#3598) Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com> * tSNE components parameter (#2803) Co-authored-by: Phil Schaf <flying-sheep@web.de> * Simplify scale (#3351) Co-authored-by: Intron7 <severin.dicks@icloud.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * remove layers test * explicit return and fix the info message * remove unnecessary ravel's * precision fix * (fix): maintain data type properly. * (fix): remove artifact storage * (refactor): use nice f-a-u typing --------- Co-authored-by: Philipp A. <flying-sheep@web.de> Co-authored-by: Selman Özleyen <32667648+selmanozleyen@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Swastik Mishra <4453983+swstkm@users.noreply.github.com> Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com> Co-authored-by: Kitsune <48340051+ch1ru@users.noreply.github.com> Co-authored-by: selmanozleyen <syozleyen@gmail.com> Co-authored-by: ilan-gold <ilanbassgold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.