Uh oh!
There was an error while loading. Please reload this page.
feat(abg)!: allow to wire typed outputs to matching typed inputs - #1624
feat(abg)!: allow to wire typed outputs to matching typed inputs#1624Vampire wants to merge 1 commit into
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ff26830 to
46ca5adCompareSo far it indeed seems to work just great. |
Vampire
commented
Aug 23, 2024
Main remaining problem is probably the naming at https://github.com/typesafegithub/github-workflows-kt/pull/1624/files#diff-76c4a08acf57b6c491c34cc60e6ad7bbc219fbd45dc0dda74550941ecac51200 :-/ |
46ca5ad to
14d4f80CompareVampire
commented
Aug 23, 2024
Of course the typing catalog should be polished to have proper output types which it currently does not have. |
14d4f80 to
f4b6351Compare3a53468 to
f0429b9CompareVampire
commented
Aug 25, 2024
Forgot the job outputs, now they are also typed :-) |
adbea5b to
59626c0CompareVampire
commented
Aug 31, 2024
And now |
90360a0 to
09d160eCompared7c1b5d to
f3b7790Comparef24be3b to
b7312edCompare3bf0f10 to
7a302adCompareb7312ed to
82626b6Compare7a302ad to
c660603Compare82626b6 to
5cf2155Comparec660603 to
79fa813Compare5cf2155 to
4b5d840Compare79fa813 to
d2f3975Compare7cf7158 to
e3fb0e7Compared2f3975 to
d20434cComparee3fb0e7 to
2167254Compared20434c to
d42909aCompare2167254 to
71c6dd8Compared42909a to
9d293a1Compare71c6dd8 to
af313d2Compare9d293a1 to
30dd897Compareaf313d2 to
ed8762bCompare30dd897 to
9d65dc9Compareed8762b to
06a5920Compare9d65dc9 to
cd64a8eCompare06a5920 to
1cc527eComparecd64a8e to
62d0334Compare1cc527e to
eab1aa8Compare62d0334 to
1692740Compare
Fixes#73
If types of input and output match, you can do
lookupOnlyExpression = cache.outputs.cacheHitIf types do not match for whatever reason, you can still do
lookupOnlyExpression = cache.outputs.cacheHit_Untypedor
or (but deprecated)
lookupOnly_Untyped = cache.outputs.cacheHit.expressionStringIf no type is declared for the output, you can still stuff the
_Untypedone into any expression input likelookupOnlyExpression = cache.outputs.cacheHit_UntypedAd-hoc outputs behave like untyped outputs in that you can stuff it into everywhere