Uh oh!
There was an error while loading. Please reload this page.
feat(abg)!: replace data class perks by code generation in bindings - #1644
Open
Vampire wants to merge 1 commit into
Open
feat(abg)!: replace data class perks by code generation in bindings#1644Vampire wants to merge 1 commit into
Vampire wants to merge 1 commit into
Conversation
CollaboratorAuthor
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Vampireforce-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
September 6, 2024 22:12
fcb93fe to
f2e6c05CompareVampireforce-pushed
the
vampire/versioned-routes
branch
from
September 8, 2024 08:10
6e0c383 to
05942abCompare
This was referenced Sep 8, 2024
Vampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 8, 2024 08:11
f2e6c05 to
f9bff8aCompareVampire
changed the base branch from
vampire/versioned-routes
to
vampire/binding-version-v2September 8, 2024 08:11
Vampireforce-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
September 8, 2024 15:23
26ff564 to
915be83CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 8, 2024 20:27
5b756f4 to
a485fe4CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 8, 2024 20:27
915be83 to
01e7a87CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 9, 2024 08:05
a485fe4 to
6c58c0dCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 9, 2024 08:05
01e7a87 to
781eb1bCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 9, 2024 10:57
6c58c0d to
66b9afdCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 9, 2024 10:57
781eb1b to
248813fCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 10, 2024 16:43
66b9afd to
f8e466fCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 10, 2024 16:43
248813f to
a5da3b1CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 23, 2024 08:13
f8e466f to
eb02b5aCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 23, 2024 08:13
a5da3b1 to
f58ac6bCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 24, 2024 00:41
eb02b5a to
36a0a91CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 24, 2024 00:41
f58ac6b to
f11c738CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 29, 2024 17:29
36a0a91 to
8895541CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 29, 2024 17:29
f11c738 to
5e87ccbCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
September 29, 2024 21:12
8895541 to
4281b5dCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
September 29, 2024 21:12
5e87ccb to
c89a7e1CompareUh oh!
There was an error while loading. Please reload this page.
| - The `equals` method will work like before. | ||
| - The `hashCode` method will work like before. | ||
| - The `toString` method will work like before. | ||
| - Destructuring assignments are not possible anymore as this will likely break silently or during |
Member
There was a problem hiding this comment.
I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
Member
There was a problem hiding this comment.
My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄
Member
There was a problem hiding this comment.
Let's see if someone has some interesting take on this: https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659
CollaboratorAuthor
There was a problem hiding this comment.
I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
It would not be, as said on Slack.
It was intentional I left them out.
And additionally the copy method now also enforces named-arguments which is also a breaking change.
So to replicate here too, the goal here was not to somehow make it compatible with the upcoming Kotlin versions, but to improve the API to the originally intended way.
That this also fixes the copy visibility thing is merely a by-product and just was the trigger to finally have a look at it.
Vampireforce-pushed
the
vampire/binding-version-v2
branch
from
October 27, 2024 03:52
4281b5d to
1f9acc7CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
October 27, 2024 03:52
c89a7e1 to
fb71bbbCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
December 8, 2024 23:08
9d293a1 to
30dd897CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
December 8, 2024 23:08
ac57787 to
6a4b37cCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
December 9, 2024 11:56
30dd897 to
9d65dc9CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
December 9, 2024 11:56
6a4b37c to
e1c02e0CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
January 4, 2025 13:33
9d65dc9 to
cd64a8eCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
January 4, 2025 13:33
e1c02e0 to
f416585CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
January 22, 2025 17:45
cd64a8e to
62d0334CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
January 22, 2025 17:45
f416585 to
38ae26eCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
January 23, 2025 00:35
62d0334 to
1692740CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
January 23, 2025 00:35
38ae26e to
78478e8CompareVampire
changed the base branch from
vampire/binding-version-v2
to
graphite-base/1644February 21, 2025 03:50
Vampire
changed the base branch from
graphite-base/1644
to
vampire/binding-version-v2February 21, 2025 03:51
Vampire
changed the base branch from
vampire/binding-version-v2
to
graphite-base/1644February 21, 2025 13:53
Vampireforce-pushed
the
graphite-base/1644
branch
from
February 21, 2025 13:58
0d20faa to
361c817CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
February 21, 2025 13:58
2e625de to
792beb4CompareVampire
changed the base branch from
graphite-base/1644
to
vampire/binding-version-v2February 21, 2025 13:58
Vampireforce-pushed
the
vampire/no-data-bindings
branch
from
February 21, 2025 14:00
792beb4 to
6edeaacCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
2 times, most recently
from
February 24, 2025 10:17
29455da to
5ea294cCompareVampireforce-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
February 24, 2025 12:37
44c7839 to
a157006CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
February 24, 2025 12:37
5ea294c to
56f3508CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
February 24, 2025 21:42
a157006 to
ff4ec7aCompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
February 24, 2025 21:42
56f3508 to
aa3ec98CompareVampireforce-pushed
the
vampire/no-data-bindings
branch
from
February 25, 2025 11:20
ff4ec7a to
63a6397CompareVampireforce-pushed
the
vampire/binding-version-v2
branch
from
February 25, 2025 11:20
aa3ec98 to
0a56a01CompareVampire
changed the base branch from
vampire/binding-version-v2
to
graphite-base/1644February 25, 2025 12:11
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1629