Uh oh!
There was an error while loading. Please reload this page.
feat(server): Add commit version significance - #2308
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Vampire
commented
Apr 25, 2026
Still missing tests and docs, so still in Draft, but the production changes should be fine already to add the If no consistency check is done, it just runs with the old commit id. If a consistency check it done, it fails the consistency check if the version points to another commit id, so this should only be used with concrete non-changeable versios, not with This also works properly with Renovate, as Renovate will update the commit id in the YAML and the version in the workflow script (if you configured it to do both chagnes in one PR) and it will build successfully, I tried locally. |
4a77e9d to
933b1aaCompare506987c to
96a2d88CompareVampire
commented
Apr 25, 2026
Ok, I think now it is also ready :-) |
96a2d88 to
deb8686Comparedeb8686 to
ce0b00dCompare5b6c090 to
be17b5cCompareaae2ea3 to
ba97651Comparebe17b5c to
a8b12c5Compareba97651 to
3797c81Comparea8b12c5 to
79ad715Compare3797c81 to
eb91d92Compare79ad715 to
b221288Compareeb91d92 to
16c5a25Compare16c5a25 to
5695a19Compare5695a19 to
6273657Compare| @file:DependsOn("actions:setup-python___commit_lenient:v6.0.0__e797f83bcb11b83ae66e0230d6156d7c80228e7c") | ||
| // Action version pinned to a commit. | ||
| @file:DependsOn("actions:github-script___commit:v9.0.0") |
There was a problem hiding this comment.
Thanks for the PR! It's a good foundation for what we need, but the design doc for this feature specifies a slightly different API: https://github.com/typesafegithub/design-docs/blob/main/2025-04-27%20Enhancements%20to%20referring%20to%20actions%20by%20commit%20hash.md. So I wouldn't skip specifying commit ID if the user uses ___commit because the idea is to cross-check the version and the commit ID - they should match.
However, what you proposed in this PR is also an interesting approach. Maybe we could expose it under ___commit_infer or sth?
I'd also like to ask for adding consuming an action this way to some tests that surface how the YAML looks like, so likely to .github/workflows/end-to-end-tests.main.kts. I know the tests for ___commit_lenient are missing - my bad, they should be there.

No description provided.