Skip to content

fix(server): prefetch the correct binding artifacts - #2298

Merged
krzema12 merged 1 commit into
mainfrom
vampire/fix-prefetching
Jun 9, 2026
Merged

fix(server): prefetch the correct binding artifacts#2298
krzema12 merged 1 commit into
mainfrom
vampire/fix-prefetching

Conversation

@Vampire

Copy link
Copy Markdown
Collaborator

No description provided.

@VampireGraphite App

Vampire commented Apr 22, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from 2bff3b1 to 9df19eaCompareApril 22, 2026 16:27
@Vampire
Vampireforce-pushed the vampire/fix-maven-metadata-artifact-name branch from 8c04cf9 to f1e0102CompareApril 23, 2026 08:05
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch 2 times, most recently from 52b8a6a to c3dce5aCompareApril 24, 2026 07:40
@Vampire
Vampireforce-pushed the vampire/fix-maven-metadata-artifact-name branch 2 times, most recently from 4315cce to ed78050CompareApril 24, 2026 13:22
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from c3dce5a to 4a77e9dCompareApril 24, 2026 13:22
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from 4a77e9d to 933b1aaCompareApril 25, 2026 21:43
@Vampire
Vampireforce-pushed the vampire/fix-maven-metadata-artifact-name branch from ed78050 to 4bd8399CompareApril 25, 2026 21:43
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from 933b1aa to 5b6c090CompareApril 27, 2026 10:43
@Vampire
Vampireforce-pushed the vampire/fix-maven-metadata-artifact-name branch from 4bd8399 to 34fae11CompareApril 27, 2026 10:43
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from 5b6c090 to be17b5cCompareMay 4, 2026 08:55
@Vampire
Vampireforce-pushed the vampire/fix-maven-metadata-artifact-name branch from 34fae11 to 254d9ccCompareMay 4, 2026 08:55
Base automatically changed from vampire/fix-maven-metadata-artifact-name to mainMay 4, 2026 11:37
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from be17b5c to a8b12c5CompareMay 4, 2026 11:41
@Vampire
Vampire changed the base branch from main to graphite-base/2298June 5, 2026 14:06
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from a8b12c5 to 79ad715CompareJune 5, 2026 14:06
@Vampire
Vampire changed the base branch from graphite-base/2298 to vampire/test-non-sense-behaviorJune 5, 2026 14:06
@Vampire
Vampire requested a review from krzema12June 5, 2026 14:08
Base automatically changed from vampire/test-non-sense-behavior to mainJune 5, 2026 18:14
@Vampire
Vampireforce-pushed the vampire/fix-prefetching branch from 79ad715 to b221288CompareJune 9, 2026 11:19
@krzema12krzema12 changed the title fix(server): Prefetch the correct binding artifactsfix(server): prefetch the correct binding artifactsJun 9, 2026
actionCoords =
bindingsServerRequest.actionCoords.copy(
version = if (commitLenient) availableVersion.getSha()!! else "$availableVersion",
comment = if (commitLenient) "$availableVersion" else null,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not a fan of logic in tests (because nothing tests it), but let's say the logic here is simple enough to turn a blind eye on it 😄

@krzema12
krzema12 merged commit cefd376 into mainJun 9, 2026
17 checks passed
@krzema12
krzema12 deleted the vampire/fix-prefetching branch June 9, 2026 14:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Vampire@krzema12