fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() - #1318

Merged
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid
Mar 10, 2026
Merged

fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start()#1318
TooTallNate merged 1 commit into
mainfrom
fix/start-encryption-deploymentid

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Summary

  • Fix: start() was not encrypting the initial workflow input when called from external contexts (e2e test runners, CLI) because it passed the raw user-provided opts to getEncryptionKeyForRun instead of including the resolved deploymentId.
  • The deploymentId was correctly resolved from world.getDeploymentId() on line 108, but never forwarded into the context object on line 127, so getEncryptionKeyForRun received undefined and silently skipped encryption.
  • Step inputs/outputs were encrypted correctly because they execute inside the Vercel Function where the local HKDF path (VERCEL=1 + VERCEL_DEPLOYMENT_KEY) is used instead.

Changes

  • packages/core/src/runtime/start.ts: Include the resolved deploymentId in the context passed to getEncryptionKeyForRun
  • packages/core/src/runtime/start.test.ts: Add test cases verifying getEncryptionKeyForRun receives the resolved deploymentId both when inferred from the environment and when explicitly provided
  • Changeset: @workflow/core patch

…art()
The start() function resolved deploymentId from world.getDeploymentId() but
then passed the original opts (without the resolved value) to
getEncryptionKeyForRun. In external contexts (e2e tests, CLI) where
deploymentId is inferred from the environment rather than explicitly provided,
this caused getEncryptionKeyForRun to receive undefined deploymentId and
silently skip encryption for the initial workflow input.
@vercel

vercelBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CopilotAI review requested due to automatic review settings March 10, 2026 22:48
@TooTallNate
TooTallNate requested a review from a team as a code ownerMarch 10, 2026 22:48
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f1ce686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production571067638
✅ 💻 Local Development612084696
✅ 📦 Local Production612084696
✅ 🐘 Local Postgres612084696
✅ 🪟 Windows550358
❌ 🌍 Community Worlds1185615189
✅ 📋 Other147027174
Total2727563643147

❌ Failed Tests

🌍 Community Worlds (56 failed)

mongodb (3 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

redis (2 failed):

  • hookWorkflow is not resumable via public webhook endpoint
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously

turso (51 failed):

  • addTenWorkflow
  • addTenWorkflow
  • wellKnownAgentWorkflow (.well-known/agent)
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • importedStepOnlyWorkflow
  • hookWorkflow
  • hookWorkflow is not resumable via public webhook endpoint
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • cancelRun - cancelling a running workflow
  • cancelRun via CLI - cancelling a running workflow
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control)

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro5107
✅ example5107
✅ express5107
✅ fastify5107
✅ hono5107
✅ nextjs-turbopack5602
✅ nextjs-webpack5602
✅ nitro5107
✅ nuxt5107
✅ sveltekit5107
✅ vite5107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable4909
✅ express-stable4909
✅ fastify-stable4909
✅ hono-stable4909
✅ nextjs-turbopack-canary5503
✅ nextjs-turbopack-stable5503
✅ nextjs-webpack-canary5503
✅ nextjs-webpack-stable5503
✅ nitro-stable4909
✅ nuxt-stable4909
✅ sveltekit-stable4909
✅ vite-stable4909
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack5503
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev302
❌ mongodb5233
✅ redis-dev302
❌ redis5323
✅ turso-dev302
❌ turso4513
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable4909
✅ e2e-local-postgres-nest-stable4909
✅ e2e-local-prod-nest-stable4909

📋 View full workflow run

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Express0.033s (+17.2% 🔺)1.006s (~)0.973s101.00x
💻 LocalNitro0.033s (+0.6%)1.005s (~)0.972s101.01x
🌐 RedisNext.js (Turbopack)0.042s (-4.7%)1.005s (~)0.963s101.30x
💻 LocalNext.js (Turbopack)0.044s (+17.7% 🔺)1.007s (~)0.962s101.36x
🐘 PostgresExpress0.055s (~)1.011s (~)0.956s101.68x
🐘 PostgresNitro0.056s (+2.7%)1.012s (~)0.955s101.72x
🌐 MongoDBNext.js (Turbopack)0.117s (+22.2% 🔺)1.008s (~)0.890s103.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express0.517s (+8.9% 🔺)2.279s (+12.8% 🔺)1.762s101.00x
▲ VercelNitro0.622s (+16.1% 🔺)2.511s (+4.4%)1.889s101.20x
▲ VercelNext.js (Turbopack)0.735s (+19.1% 🔺)2.500s (+9.5% 🔺)1.765s101.42x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)1.095s (-0.8%)2.006s (~)0.910s101.00x
🌐 RedisNext.js (Turbopack)1.101s (~)2.006s (~)0.905s101.01x
💻 LocalExpress1.104s (+2.9%)2.006s (~)0.902s101.01x
💻 LocalNitro1.104s (~)2.006s (~)0.902s101.01x
🐘 PostgresExpress1.130s (~)2.012s (~)0.882s101.03x
🐘 PostgresNitro1.133s (~)2.013s (~)0.879s101.03x
🌐 MongoDBNext.js (Turbopack)1.305s (~)2.008s (~)0.703s101.19x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.023s (-2.2%)3.481s (+1.1%)1.458s101.00x
▲ VercelNitro2.043s (+1.0%)3.652s (-2.2%)1.608s101.01x
▲ VercelNext.js (Turbopack)2.047s (~)3.567s (+5.5% 🔺)1.520s101.01x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)10.637s (~)11.021s (~)0.384s31.00x
💻 LocalNext.js (Turbopack)10.681s (~)11.023s (~)0.342s31.00x
💻 LocalNitro10.793s (~)11.024s (~)0.231s31.01x
💻 LocalExpress10.794s (+2.7%)11.025s (~)0.231s31.01x
🐘 PostgresExpress10.821s (-0.7%)11.045s (~)0.224s31.02x
🐘 PostgresNitro10.863s (~)11.046s (~)0.183s31.02x
🌐 MongoDBNext.js (Turbopack)12.213s (~)13.019s (~)0.806s31.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express16.500s (-7.1% 🟢)17.831s (-8.2% 🟢)1.331s21.00x
▲ VercelNitro16.702s (-6.1% 🟢)17.985s (-7.4% 🟢)1.283s21.01x
▲ VercelNext.js (Turbopack)16.956s (~)18.637s (+1.1%)1.681s21.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)26.507s (~)27.049s (~)0.541s31.00x
💻 LocalNext.js (Turbopack)26.918s (~)27.054s (~)0.136s31.02x
🐘 PostgresExpress26.944s (~)27.059s (-2.4%)0.115s31.02x
🐘 PostgresNitro26.979s (~)27.394s (+1.2%)0.416s31.02x
💻 LocalNitro27.231s (~)28.052s (~)0.821s31.03x
💻 LocalExpress27.274s (+2.9%)28.054s (+3.7%)0.780s31.03x
🌐 MongoDBNext.js (Turbopack)30.546s (~)31.050s (~)0.504s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro42.803s (-5.7% 🟢)44.882s (-4.1%)2.079s21.00x
▲ VercelExpress43.404s (-3.2%)45.032s (-3.0%)1.628s21.01x
▲ VercelNext.js (Turbopack)43.429s (-6.6% 🟢)45.304s (-5.8% 🟢)1.874s21.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)53.076s (-0.7%)53.594s (-0.9%)0.518s21.00x
🐘 PostgresNitro53.967s (~)54.103s (~)0.136s21.02x
🐘 PostgresExpress54.032s (~)54.103s (~)0.071s21.02x
💻 LocalNext.js (Turbopack)55.383s (~)56.103s (~)0.719s21.04x
💻 LocalNitro56.255s (+0.6%)57.104s (+1.8%)0.849s21.06x
💻 LocalExpress56.373s (+3.6%)57.108s (+3.6%)0.735s21.06x
🌐 MongoDBNext.js (Turbopack)61.138s (~)62.100s (+1.7%)0.962s21.15x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express92.401s (-3.8%)93.928s (-3.6%)1.527s11.00x
▲ VercelNext.js (Turbopack)97.802s (~)99.711s (+0.6%)1.909s11.06x
▲ VercelNitro103.235s (+7.6% 🔺)104.629s (+6.2% 🔺)1.394s11.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.284s (+3.2%)2.006s (~)0.722s151.00x
🐘 PostgresNitro1.358s (-1.4%)2.011s (~)0.653s151.06x
🐘 PostgresExpress1.367s (~)2.011s (~)0.644s151.06x
💻 LocalNext.js (Turbopack)1.393s (-3.2%)2.006s (~)0.613s151.08x
💻 LocalExpress1.412s (+5.0% 🔺)2.006s (~)0.594s151.10x
💻 LocalNitro1.416s (~)2.006s (~)0.589s151.10x
🌐 MongoDBNext.js (Turbopack)2.137s (~)3.010s (~)0.872s101.66x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.436s (+7.3% 🔺)3.831s (+5.5% 🔺)1.395s81.00x
▲ VercelNext.js (Turbopack)3.006s (+32.6% 🔺)4.452s (+17.3% 🔺)1.446s71.23x
▲ VercelNitro3.024s (+9.3% 🔺)4.566s (+8.6% 🔺)1.542s71.24x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro1.994s (-4.9%)2.517s (-8.3% 🟢)0.523s121.00x
🐘 PostgresExpress2.032s (+1.0%)2.518s (-3.1%)0.485s121.02x
🌐 RedisNext.js (Turbopack)2.477s (~)3.008s (~)0.531s101.24x
💻 LocalNext.js (Turbopack)2.558s (-5.1% 🟢)3.007s (~)0.449s101.28x
💻 LocalNitro2.657s (+3.2%)3.007s (~)0.350s101.33x
💻 LocalExpress2.675s (+17.4% 🔺)3.008s (~)0.332s101.34x
🌐 MongoDBNext.js (Turbopack)4.748s (+1.4%)5.178s (~)0.431s62.38x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.582s (+1.3%)3.982s (-0.8%)1.400s81.00x
▲ VercelNext.js (Turbopack)2.891s (-15.2% 🟢)4.194s (-9.7% 🟢)1.302s81.12x
▲ VercelExpress2.984s (+1.0%)4.157s (-3.2%)1.173s81.16x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.all with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Nitro3.313s (-17.7% 🟢)4.147s (-12.4% 🟢)0.835s81.00x
🌐 RedisNext.js (Turbopack)4.033s (-4.3%)4.581s (-8.6% 🟢)0.548s71.22x
🐘 PostgresExpress4.219s (+7.9% 🔺)4.610s (-2.8%)0.391s71.27x
💻 LocalNext.js (Turbopack)6.265s (-16.3% 🟢)6.817s (-15.0% 🟢)0.551s51.89x
💻 LocalExpress7.699s (+18.0% 🔺)8.021s (+14.3% 🔺)0.322s42.32x
💻 LocalNitro7.838s (+8.7% 🔺)8.019s (~)0.181s42.37x
🌐 MongoDBNext.js (Turbopack)9.977s (~)10.685s (+3.3%)0.709s33.01x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Next.js (Turbopack)2.866s (-3.5%)4.320s (+2.1%)1.454s71.00x
▲ VercelNitro2.924s (-10.3% 🟢)4.142s (-19.4% 🟢)1.218s81.02x
▲ VercelExpress2.947s (-6.7% 🟢)4.332s (+0.8%)1.385s71.03x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 10 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🌐 Redis🥇 Next.js (Turbopack)1.245s (-0.8%)2.006s (~)0.761s151.00x
🐘 PostgresNitro1.386s (-1.2%)2.012s (~)0.626s151.11x
🐘 PostgresExpress1.391s (+1.0%)2.012s (~)0.620s151.12x
💻 LocalNext.js (Turbopack)1.395s (-5.9% 🟢)2.006s (~)0.611s151.12x
💻 LocalNitro1.446s (+0.7%)2.005s (~)0.559s151.16x
💻 LocalExpress1.453s (+4.6%)2.006s (~)0.553s151.17x
🌐 MongoDBNext.js (Turbopack)2.163s (-0.6%)3.008s (~)0.845s101.74x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro2.103s (-11.1% 🟢)3.586s (-5.0%)1.483s91.00x
▲ VercelExpress2.118s (-11.8% 🟢)3.500s (-10.1% 🟢)1.382s91.01x
▲ VercelNext.js (Turbopack)2.184s (+5.8% 🔺)3.554s (+3.5%)1.370s91.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 25 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express2.016s (-5.7% 🟢)2.601s (-8.2% 🟢)0.585s121.00x
🐘 PostgresNitro2.031s (+3.1%)2.479s (-1.4%)0.447s131.01x
🌐 RedisNext.js (Turbopack)2.488s (-1.1%)3.008s (~)0.519s101.23x
💻 LocalNext.js (Turbopack)2.512s (-8.9% 🟢)3.008s (~)0.496s101.25x
💻 LocalNitro2.775s (+2.9%)3.008s (~)0.234s101.38x
💻 LocalExpress2.809s (+18.5% 🔺)3.109s (+3.4%)0.299s101.39x
🌐 MongoDBNext.js (Turbopack)4.730s (+0.5%)5.176s (~)0.446s62.35x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express2.610s (+5.9% 🔺)3.873s (+2.9%)1.263s81.00x
▲ VercelNext.js (Turbopack)2.848s (+14.1% 🔺)4.023s (+12.6% 🔺)1.175s81.09x
▲ VercelNitro2.916s (+18.3% 🔺)4.451s (+14.9% 🔺)1.535s71.12x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
🐘 Postgres🥇 Express3.834s (-4.1%)4.315s (-6.2% 🟢)0.481s71.00x
🐘 PostgresNitro3.868s (+4.9%)4.449s (-3.2%)0.581s71.01x
🌐 RedisNext.js (Turbopack)3.992s (~)4.294s (-3.2%)0.303s71.04x
💻 LocalNext.js (Turbopack)7.092s (-4.2%)7.768s (~)0.676s41.85x
💻 LocalNitro8.206s (+4.6%)9.023s (+9.1% 🔺)0.818s42.14x
💻 LocalExpress8.588s (+25.5% 🔺)9.023s (+28.6% 🔺)0.436s42.24x
🌐 MongoDBNext.js (Turbopack)9.919s (~)10.350s (~)0.431s32.59x
🐘 PostgresNext.js (Turbopack)⚠️missing----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Express3.064s (-2.0%)4.783s (+10.7% 🔺)1.719s71.00x
▲ VercelNext.js (Turbopack)3.275s (+8.9% 🔺)4.480s (+3.3%)1.206s81.07x
▲ VercelNitro3.570s (+16.2% 🔺)4.867s (+14.7% 🔺)1.297s71.17x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks(includes TTFB metrics)
workflow with stream

💻 Local Development

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
💻 Local🥇 Next.js (Turbopack)0.145s (-6.9% 🟢)1.001s (~)0.011s (-9.1% 🟢)1.017s (~)0.872s101.00x
🌐 RedisNext.js (Turbopack)0.150s (+4.2%)1.000s (~)0.002s (+21.4% 🔺)1.007s (~)0.858s101.03x
💻 LocalExpress0.174s (+59.5% 🔺)1.003s (~)0.012s (+16.7% 🔺)1.018s (~)0.843s101.20x
💻 LocalNitro0.177s (+3.5%)1.003s (~)0.012s (+3.6%)1.017s (~)0.841s101.22x
🐘 PostgresNitro0.189s (-12.6% 🟢)0.996s (~)0.001s (~)1.013s (~)0.824s101.30x
🐘 PostgresExpress0.204s (~)0.992s (~)0.001s (-12.5% 🟢)1.012s (~)0.808s101.41x
🌐 MongoDBNext.js (Turbopack)0.503s (-1.2%)0.945s (+1.4%)0.002s (~)1.010s (~)0.507s103.47x
🐘 PostgresNext.js (Turbopack)⚠️missing-----

▲ Production (Vercel)

WorldFrameworkWorkflow TimeTTFBSlurpWall TimeOverheadSamplesvs Fastest
▲ Vercel🥇 Nitro1.624s (+4.2%)2.540s (+24.4% 🔺)0.024s (+344.4% 🔺)3.148s (+23.1% 🔺)1.524s101.00x
▲ VercelExpress1.644s (+5.4% 🔺)2.422s (+9.9% 🔺)0.006s (+10.9% 🔺)2.930s (+7.6% 🔺)1.286s101.01x
▲ VercelNext.js (Turbopack)1.773s (+17.2% 🔺)2.934s (+32.5% 🔺)0.006s (-44.0% 🟢)3.540s (+32.4% 🔺)1.767s101.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World🥇 Fastest FrameworkWins
💻 LocalNext.js (Turbopack)11/12
🐘 PostgresExpress6/12
▲ VercelExpress7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework🥇 Fastest WorldWins
Express🐘 Postgres6/12
Next.js (Turbopack)🌐 Redis8/12
Nitro🐘 Postgres6/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes initial workflow input encryption in start() when invoked outside the Vercel serverless runtime by ensuring getEncryptionKeyForRun(runId, context) receives the resolveddeploymentId (including cases where it’s inferred via world.getDeploymentId()).

Changes:

  • Pass resolved deploymentId into the context object provided to world.getEncryptionKeyForRun() in start().
  • Add tests asserting getEncryptionKeyForRun receives the resolved deploymentId both when inferred and when explicitly provided.
  • Add a changeset for a @workflow/core patch release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/core/src/runtime/start.tsForwards resolved deploymentId to getEncryptionKeyForRun so encryption key resolution works in external contexts.
packages/core/src/runtime/start.test.tsAdds regression tests to ensure deploymentId is present in the key-resolution context.
.changeset/fix-start-encryption-deploymentid.mdDocuments the bugfix and bumps @workflow/core with a patch changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TooTallNate
TooTallNate enabled auto-merge (squash) March 10, 2026 22:54
@TooTallNate
TooTallNate merged commit 854a25f into mainMar 10, 2026
167 of 172 checks passed
@TooTallNate
TooTallNate deleted the fix/start-encryption-deploymentid branch March 10, 2026 23:10
pranaygp added a commit that referenced this pull request Mar 12, 2026
…ignal
* origin/main: (26 commits)
Fix flaky streamer test ENOENT when chunks directory does not exist yet (#1330)
Version Packages (beta) (#1325)
[web-shared] Improve workflow observability event list UX (#1337)
feat: add `exists` getter to `Run` class (#1336)
Support client-side tools in DurableAgent (#1329)
[world-postgres] [world-local] Execute Graphile jobs directly instead of defering to world-local queue (#1334)
Merge CLAUDE.md into AGENTS.md and symlink CLAUDE.md (#1326)
[web] Polish loading indicators (#1327)
Fix flaky webhookWorkflow e2e test by polling instead of fixed sleep (#1328)
feat: support `deploymentId: 'latest'` in `start()` to resolve most recent deployment (#1317)
Fix bug where the SWC compiler bug prunes step-only imports in the client-mode transformation
[web] [world-vercel] Ensure user-passed run IDs are URL encoded and call out self-hosted security (#1322)
Version Packages (beta) (#1306)
Remove hard-coded VERCEL_DEPLOYMENT_KEY from nextjs-turbopack workbench (#1319)
fix(web): move react-router deps to devDependencies (#1265)
fix(ai): use workspace:* for workflow peer dependency (#1320)
fix(core): pass resolved deploymentId to getEncryptionKeyForRun in start() (#1318)
fix: surface 429 rate-limit errors in e2e tests and CLI (#1309)
fix(world-local): return HTTP 200 instead of 503 for queue timeout re-enqueue signals (#1307)
[web-shared] [cli] Refactor observability data fetching (#1261)
...
# Conflicts:
#	packages/core/e2e/e2e.test.ts
#	packages/web-shared/src/components/sidebar/attribute-panel.tsx
#	workbench/example/workflows/99_e2e.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@karthikscale3