Uh oh!
There was an error while loading. Please reload this page.
Revert "Inline class serialization registration to fix 3rd-party package support" - #1493
Merged
pranaygp merged 1 commit intoMar 24, 2026
Conversation
…age supp…" This reverts commit 7dcddb5.
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (33 failed)astro (5 failed):
example (2 failed):
express (7 failed):
fastify (1 failed):
hono (3 failed):
nextjs-turbopack (4 failed):
nextjs-webpack (1 failed):
nitro (2 failed):
nuxt (3 failed):
sveltekit (2 failed):
vite (3 failed):
🌍 Community Worlds (56 failed)mongodb (3 failed):
redis (2 failed):
turso (51 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
karthikscale3
approved these changes
Mar 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
pranaygp
deleted the
revert-1480-nrajlich/inline-class-serialization-registration
branch
March 24, 2026 00:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the prior change that inlined class-serialization registration logic inside SWC-generated output, restoring the previous approach of importing and calling registerSerializationClass from workflow/internal/class-serialization. This aims to fix widespread unit test breakage currently on main.
Changes:
- Update SWC transform to generate
import { registerSerializationClass } from "workflow/internal/class-serialization"and emitregisterSerializationClass(classId, ClassName)calls instead of an inlined IIFE. - Refresh SWC plugin fixtures/snapshots to match the reverted generated output across workflow/step/client modes.
- Update SWC plugin spec docs and remove the now-obsolete changeset describing the inlining approach.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/swc-plugin-workflow/transform/src/lib.rs | Reverts transform output back to import-based class registration and updates import insertion logic. |
| packages/core/src/class-serialization.ts | Updates docstring to reflect SWC plugin usage expectations. |
| packages/swc-plugin-workflow/spec.md | Updates documentation examples to show registerSerializationClass import/calls rather than an inlined IIFE. |
| .changeset/inline-class-serialization.md | Removes the changeset that described the reverted inlining behavior. |
| packages/swc-plugin-workflow/transform/tests/fixture/step-with-this-arguments-super/output-workflow.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/step-with-this-arguments-super/output-step.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/step-with-this-arguments-super/output-client.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/static-method-step/output-workflow.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/static-method-step/output-step.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/static-method-step/output-client.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/instance-method-step/output-workflow.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/instance-method-step/output-step.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/instance-method-step/output-client.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/instance-method-nested-step/output-workflow.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/instance-method-nested-step/output-step.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/instance-method-nested-step/output-client.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization/output-workflow.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization/output-step.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization/output-client.js | Updates expected generated output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization-local-const/output-workflow.js | Updates expected generated output to use registerSerializationClass (multiple classes). |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization-local-const/output-step.js | Updates expected generated output to use registerSerializationClass (multiple classes). |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization-local-const/output-client.js | Updates expected generated output to use registerSerializationClass (multiple classes). |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization-imported/output-workflow.js | Updates expected generated output to use registerSerializationClass (multiple classes). |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization-imported/output-step.js | Updates expected generated output to use registerSerializationClass (multiple classes). |
| packages/swc-plugin-workflow/transform/tests/fixture/custom-serialization-imported/output-client.js | Updates expected generated output to use registerSerializationClass (multiple classes). |
| packages/swc-plugin-workflow/transform/tests/fixture/class-expression-binding-name/output-workflow.js | Updates expected generated output to use registerSerializationClass for class expressions. |
| packages/swc-plugin-workflow/transform/tests/fixture/class-expression-binding-name/output-step.js | Updates expected generated output to use registerSerializationClass for class expressions. |
| packages/swc-plugin-workflow/transform/tests/fixture/class-expression-binding-name/output-client.js | Updates expected generated output to use registerSerializationClass for class expressions. |
| packages/swc-plugin-workflow/transform/tests/errors/instance-methods/output-workflow.js | Updates expected error fixture output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/errors/instance-methods/output-step.js | Updates expected error fixture output to use registerSerializationClass. |
| packages/swc-plugin-workflow/transform/tests/errors/instance-methods/output-client.js | Updates expected error fixture output to use registerSerializationClass. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4448
to
+4450
| // In step mode, we need: | ||
| // 1. registerSerializationClass(classId, ClassName) - for deserialization | ||
| // 2. ClassName.classId = "..." - for serialization (though not typically needed in step mode) |
There was a problem hiding this comment.
The comment suggests step mode needs both registerSerializationClass(...) and a separate ClassName.classId = "..." assignment, but registerSerializationClass already defines the non-enumerable classId property. Consider updating/removing the second bullet to match the actual generated behavior.
Suggested change
| // In step mode, we need: | |
| // 1. registerSerializationClass(classId, ClassName) - for deserialization | |
| // 2. ClassName.classId = "..." - for serialization (though not typically needed in step mode) | |
| // In step mode, we register classes with: | |
| // registerSerializationClass(classId, ClassName) | |
| // This defines the non-enumerable `classId` property used for (de)serialization. |
| * self-contained IIFE (using the same globalThis Symbol-keyed registry), | ||
| * so this function is no longer imported by generated code. It is retained | ||
| * for programmatic use and testing. | ||
| * Called by the SWC plugin in both step mode and workflow mode. |
There was a problem hiding this comment.
Docstring says this is called by the SWC plugin in step mode and workflow mode, but the plugin also imports/calls registerSerializationClass in client mode (see generated fixtures and transform logic). Updating the comment to include client mode would keep the docs accurate for consumers reading this file.
Suggested change
| *CalledbytheSWCplugininbothstepmodeandworkflowmode. | |
| *CalledbytheSWCplugininstepmode,workflowmode,andclientmode. |
Comment on lines
4870
to
4873
| match self.mode { | ||
| TransformMode::Workflow => { | ||
| // No imports needed for workflow mode | ||
| // Class serialization registration is inlined (no import needed) | ||
| } |
There was a problem hiding this comment.
The transform has non-trivial Program::Script handling here, but the fixture harness currently runs with module: Some(true) (so Script codepaths aren’t exercised). Consider adding a test fixture that runs with module: Some(false) and includes a serializable class to prevent regressions in this branch.
| @@ -5033,18 +4870,25 @@ impl VisitMut for StepTransform { | |||
| match self.mode { | |||
| TransformMode::Workflow => { | |||
| // No imports needed for workflow mode | |||
There was a problem hiding this comment.
In the Program::Script branch, workflow mode doesn't handle classes_needing_serialization at all (no registerSerializationClass import and no registrations), whereas the Program::Module branch does. If the input is parsed as a Script and contains serializable classes, workflow-mode output will leave them unregistered and break class (de)serialization.
Suggested change
| // No imports needed for workflow mode | |
| // In workflow mode, ensure class serialization support if needed | |
| let needs_class_serialization = | |
| !self.classes_needing_serialization.is_empty(); | |
| if needs_class_serialization { | |
| module_items.push(self.create_class_serialization_import()); | |
| } |
Comment on lines
4874
to
+4882
| TransformMode::Step => { | ||
| let needs_class_serialization = | ||
| !self.classes_needing_serialization.is_empty(); | ||
| if !self.registration_calls.is_empty() { | ||
| module_items.push(self.create_private_imports(true, false)); | ||
| } | ||
| // Class serialization registration is inlined (no import needed) | ||
| if needs_class_serialization { | ||
| module_items.push(self.create_class_serialization_import()); | ||
| } |
There was a problem hiding this comment.
In the Program::Script branch, step mode conditionally adds the registerSerializationClass import (needs_class_serialization), but this branch does not appear to append any registerSerializationClass(classId, ClassName) statements for classes_needing_serialization (unlike the Program::Module branch). That would leave classes unregistered in step-mode script transforms.
Comment on lines
+4461
to
+4493
| let registration_call = Stmt::Expr(ExprStmt { | ||
| span: DUMMY_SP, | ||
| expr: Box::new(Expr::Call(CallExpr { | ||
| span: DUMMY_SP, | ||
| ctxt: SyntaxContext::empty(), | ||
| callee: Callee::Expr(Box::new(Expr::Ident(Ident::new( | ||
| "registerSerializationClass".into(), | ||
| DUMMY_SP, | ||
| SyntaxContext::empty(), | ||
| )))), | ||
| args: vec![ | ||
| // First argument: class ID | ||
| ExprOrSpread { | ||
| spread: None, | ||
| expr: Box::new(Expr::Lit(Lit::Str(Str { | ||
| span: DUMMY_SP, | ||
| value: class_id.into(), | ||
| raw: None, | ||
| }))), | ||
| }, | ||
| // Second argument: ClassName | ||
| ExprOrSpread { | ||
| spread: None, | ||
| expr: Box::new(Expr::Ident(Ident::new( | ||
| class_name.into(), | ||
| DUMMY_SP, | ||
| SyntaxContext::empty(), | ||
| ))), | ||
| }, | ||
| ], | ||
| type_args: None, | ||
| })), | ||
| }); |
There was a problem hiding this comment.
This step-mode loop re-implements the AST for registerSerializationClass(...) inline. Since create_class_serialization_registration() already exists (and is used for workflow/client), it would be less error-prone to reuse that helper here to avoid the different modes drifting over time.
Suggested change
| let registration_call = Stmt::Expr(ExprStmt{ | |
| span:DUMMY_SP, | |
| expr:Box::new(Expr::Call(CallExpr{ | |
| span:DUMMY_SP, | |
| ctxt:SyntaxContext::empty(), | |
| callee:Callee::Expr(Box::new(Expr::Ident(Ident::new( | |
| "registerSerializationClass".into(), | |
| DUMMY_SP, | |
| SyntaxContext::empty(), | |
| )))), | |
| args: vec![ | |
| // First argument: class ID | |
| ExprOrSpread{ | |
| spread:None, | |
| expr:Box::new(Expr::Lit(Lit::Str(Str{ | |
| span:DUMMY_SP, | |
| value: class_id.into(), | |
| raw:None, | |
| }))), | |
| }, | |
| // Second argument: ClassName | |
| ExprOrSpread{ | |
| spread:None, | |
| expr:Box::new(Expr::Ident(Ident::new( | |
| class_name.into(), | |
| DUMMY_SP, | |
| SyntaxContext::empty(), | |
| ))), | |
| }, | |
| ], | |
| type_args:None, | |
| })), | |
| }); | |
| let registration_call = | |
| self.create_class_serialization_registration(&class_id,&class_name); |
pranaygp added a commit
that referenced
this pull request
Mar 24, 2026
…naygp-db9e68c1 * 'main' of https://github.com/vercel/workflow: (32 commits) chore: bump @nestjs/* to ^11.1.17 (#1497) chore: bump hono to ^4.12.8 (#1495) Revert "Inline class serialization registration to fix 3rd-party package supp…" (#1493) [world] Add stream pagination and metadata endpoints (#1470) [cli] [world-local] Ensure update checks don't suggest upgrading from stable release to pre-releases (#1490) Remove NestJS Vercel integration while in experimental phase (#1485) feat: export semantic error types and add API reference docs (#1447) feat: enforce max queue deliveries in handlers with graceful failure (#1344) [world-postgres] Migrate client from `postgres.js` to `pg` (#1484) Inline class serialization registration to fix 3rd-party package support (#1480) [ai] Add experimental_context to DurableAgentOptions (#1489) [ai] Expose configured tools on DurableAgent instances (#1488) fix(builders): catch node builtin usage when entry fields diverge (#1455) [web-shared] Fix timeline duration format and precision (#1482) [cli] Add bulk cancel, --status filter, fix step JSON hydration (#1467) [utils] Re-export parseName utilities and add workflow/observability module (#1453) [o11y] Polish display when run data has expired (#1438) Add CommonJS `require()` support for class serialization detection in SWC plugin (#1144) fix(next): stabilize deferred canary e2e in nextjs workbenches (#1468) [web] Support legacy newline-delimited stream format in `useStreamReader` (#1473) ...
pranaygp added a commit
that referenced
this pull request
Mar 24, 2026
…naygp-6fadd605 * 'main' of https://github.com/vercel/workflow: (73 commits) chore: bump next to 16.2.1 and fix deferred build (#1496) chore: bump nitropack to ^2.13.1 (#1501) chore: bump nuxt ecosystem dependencies (#1500) chore: bump sveltekit ecosystem (#1498) chore: bump express and fastify in workbenches (#1499) chore: bump @nestjs/* to ^11.1.17 (#1497) chore: bump hono to ^4.12.8 (#1495) Revert "Inline class serialization registration to fix 3rd-party package supp…" (#1493) [world] Add stream pagination and metadata endpoints (#1470) [cli] [world-local] Ensure update checks don't suggest upgrading from stable release to pre-releases (#1490) Remove NestJS Vercel integration while in experimental phase (#1485) feat: export semantic error types and add API reference docs (#1447) feat: enforce max queue deliveries in handlers with graceful failure (#1344) [world-postgres] Migrate client from `postgres.js` to `pg` (#1484) Inline class serialization registration to fix 3rd-party package support (#1480) [ai] Add experimental_context to DurableAgentOptions (#1489) [ai] Expose configured tools on DurableAgent instances (#1488) fix(builders): catch node builtin usage when entry fields diverge (#1455) [web-shared] Fix timeline duration format and precision (#1482) [cli] Add bulk cancel, --status filter, fix step JSON hydration (#1467) ... # Conflicts: # packages/core/src/runtime/start.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1480
All unit tests are breaking on main