Uh oh!
There was an error while loading. Please reload this page.
Default source maps to dev-on / prod-off - #2529
Merged
Merged
Conversation
Inline source maps are embedded in the step bundle and the intermediate workflow VM bundle, which bloats production function bundles (a problem for the Vercel 250MB limit) even though maps only help when reading a stack trace. Make the default environment-aware in @workflow/builders: inline in development (next dev / nitro dev / Vite-based dev servers, detected via config.watch or NODE_ENV=development) and off in production. The `sourcemap` config option and `WORKFLOW_SOURCEMAP` env var still override in either environment. A production build with no override also drops the source-map-support shim from the Vercel step function. Keep runtime stack remapping graceful and fast when maps are absent (@workflow/core): short-circuit when no frame references the workflow file and memoize the parsed map (or its absence) per bundle, so production failures don't rescan the bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b2c23f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
VaguelySerious
approved these changes
Jun 18, 2026
The e2e error-stack tests gate source-map assertions on hasWorkflowSourceMaps() and hasStepSourceMaps(). Now that source maps default to off in production builds, update those helpers: - hasWorkflowSourceMaps(): false for all production builds (local prod, postgres, Vercel — keyed off DEV_TEST_CONFIG), and exclude nest in dev (the Nest integration builds with watch:false / no NODE_ENV=development, so its bundles have no maps). - hasStepSourceMaps(): nest now resolves to a production build (maps off) in both dev and prod. Add unit cases for the dev-vs-prod and nest behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
No backport to The core change (env-aware dev-on/prod-off source map default) builds on the To override, re-run the Backport to stable workflow manually via |
This was referenced Jun 19, 2026
pranaygp added a commit
that referenced
this pull request
Jun 22, 2026
…testing * origin/main: Version Packages (beta) (#2540) perf(core): memoize step return value hydration across inline replays (#2472) [core] Fix abort signal not reflected in subsequent step (replay-ordering flake) (#2412) Amend lazy discovery removal changeset (#2560) [docs] Document minimum SDK version for using hook.getConflict (#2423) Update default CODEOWNERS (#2556) Optimize and fix the default eager build mode (#2546) Revert "fix(world-vercel): cancel v4 event frame stream on early exit (#2547)" (#2554) [core] Turbo mode: fast-path the first invocation (#2526) Remove lazy discovery from workflow/next (#2545) fix(world-vercel): cancel v4 event frame stream on early exit (#2547) feat(docs): add eve and AI SDK to product switcher (#2543) [vitest] Fix local imports failing to load in test step bundles (#2351) [builders] Fix unicode-escape crash in workflow graph extraction (#2324) Version Packages (beta) (#2495) otel(world-vercel): inject trace context on v4 event requests (#2533) Bump undici to 7.28.0 (#2534) Default source maps to dev-on / prod-off (#2529) otel: nest linked-mode invocations under the delivery context (route + execution in one trace) (#2527) perf(core): parallel inline steps + optimistic lazy step start (#2516)
pranaygp added a commit
to marcopiraccini/workflow
that referenced
this pull request
Jun 22, 2026
* origin/main: (120 commits) Version Packages (beta) (vercel#2540) perf(core): memoize step return value hydration across inline replays (vercel#2472) [core] Fix abort signal not reflected in subsequent step (replay-ordering flake) (vercel#2412) Amend lazy discovery removal changeset (vercel#2560) [docs] Document minimum SDK version for using hook.getConflict (vercel#2423) Update default CODEOWNERS (vercel#2556) Optimize and fix the default eager build mode (vercel#2546) Revert "fix(world-vercel): cancel v4 event frame stream on early exit (vercel#2547)" (vercel#2554) [core] Turbo mode: fast-path the first invocation (vercel#2526) Remove lazy discovery from workflow/next (vercel#2545) fix(world-vercel): cancel v4 event frame stream on early exit (vercel#2547) feat(docs): add eve and AI SDK to product switcher (vercel#2543) [vitest] Fix local imports failing to load in test step bundles (vercel#2351) [builders] Fix unicode-escape crash in workflow graph extraction (vercel#2324) Version Packages (beta) (vercel#2495) otel(world-vercel): inject trace context on v4 event requests (vercel#2533) Bump undici to 7.28.0 (vercel#2534) Default source maps to dev-on / prod-off (vercel#2529) otel: nest linked-mode invocations under the delivery context (route + execution in one trace) (vercel#2527) perf(core): parallel inline steps + optimistic lazy step start (vercel#2516) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inline source maps are base64-embedded into the step bundle and the intermediate workflow VM bundle. Today both default to
'inline'unconditionally, which bloats production function bundles — a real problem for the Vercel 250MB function limit — even though source maps only pay off when a human is reading a stack trace (i.e. during development).This makes the default environment-aware:
next dev,nitro dev, Vite-based dev servers) → inline source maps on, so step/workflow-VM stack traces point at your source files.source-map-supportruntime shim from the Vercel step function (shouldAddSourcemapSupport: false).Dev is detected via
config.watch === true || process.env.NODE_ENV === 'development', which covers next/nitro/nest (watch) and astro/sveltekit/vite (NODE_ENV), and errs toward off when ambiguous (CLI / Vercel production builds).The
sourcemapconfig option and theWORKFLOW_SOURCEMAPenv var still override the default in either environment. Precedence is unchanged: explicit config >WORKFLOW_SOURCEMAP> environment-aware default.Runtime
remapErrorStackalready no-ops when a bundle has no inline map, but it scanned the whole (~MB) bundle on every workflow failure. Now it:TraceMap(or its absence) per bundle in a small LRU,so production failures (maps off) scan at most once, then are O(1). Public behavior of
remapErrorStackis unchanged.Changes
@workflow/builders(minor):isDevelopmentBuild/defaultSourcemapMode; step + intermediate-workflow bundles use the env-aware default;sourcemapsEnableduses it too.@workflow/core(patch): faster, still-gracefulremapErrorStack.resolve-sourcemap.test.ts,source-map.test.ts).Verification
Built
workbench/examplevia thevercel-build-output-apitarget:shouldAddSourcemapSupportWORKFLOW_SOURCEMAP=inlineNODE_ENV=developmentUnit suites pass:
@workflow/builders(179) and@workflow/core(1254).🤖 Generated with Claude Code
Docs Preview
Changed docs pages on the
workflow-docspreview (behind Vercel deployment protection — team access required):withWorkflow— Source maps