Uh oh!
There was an error while loading. Please reload this page.
fix(test): rewrite vitest self-references in globals.d.ts for type-aware linting - #1177
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
MemberAuthor
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2 added a commit
that referenced
this pull request
Mar 28, 2026
…orce-migrate mode In `rewriteStandaloneProject`, when `VITE_PLUS_FORCE_MIGRATE=1`: - The pnpm overrides didn't include `vite-plus` itself (only vite, vitest, etc.) - The devDependency wasn't updated if `vite-plus` already existed This caused ecosystem-ci to install the published `vite-plus@0.1.14` instead of the local `vite-plus@0.0.0` tgz, failing the `verify-install.ts` check. Closes#1177
fengmk2 added a commit
to why-reproductions-are-required/vite-plus-vitest-global-type-minimal-repro
that referenced
this pull request
Mar 28, 2026
fengmk2
commented
Mar 28, 2026
MemberAuthor
fengmk2
marked this pull request as ready for review
March 28, 2026 07:41
This was referenced Mar 28, 2026
4 tasks
fengmk2force-pushed
the
fix-vitest-globals
branch
from
March 29, 2026 11:36
fd1b75e to
7c58334Comparefengmk2force-pushed
the
fix-vitest-globals
branch
from
March 29, 2026 14:52
7c58334 to
dfc2d61CompareMerge activity
|
…are linting (#1177) The bundled globals.d.ts declares types like `typeof import('vitest')['test']`, but `vitest` is not resolvable from the @voidzero-dev/vite-plus-test package context in pnpm's strict node_modules layout. TypeScript silently treats the unresolved import as `any`, but oxlint's type-aware linting treats it as an `error` type, causing `no-unsafe-call` errors. Fix by rewriting `import('vitest')` to `import('@voidzero-dev/vite-plus-test')` during the bundleVitest() copy step, making it a self-reference that resolves correctly via Node.js package self-referencing. Also adds the vite-plus-vitest-global-type-minimal-repro project to ecosystem-ci.
graphite-appBotforce-pushed
the
fix-vitest-globals
branch
from
March 29, 2026 15:33
dfc2d61 to
33fbc2cCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled globals.d.ts declares types like
typeof import('vitest')['test'],but
vitestis not resolvable from the @voidzero-dev/vite-plus-test packagecontext in pnpm's strict node_modules layout. TypeScript silently treats the
unresolved import as
any, but oxlint's type-aware linting treats it as anerrortype, causingno-unsafe-callerrors.Fix by rewriting
import('vitest')toimport('@voidzero-dev/vite-plus-test')during the bundleVitest() copy step, making it a self-reference that resolves
correctly via Node.js package self-referencing.
Also adds the vite-plus-vitest-global-type-minimal-repro project to ecosystem-ci.