Uh oh!
There was an error while loading. Please reload this page.
fix: stop intercepting vite as vp and synthesize vpr in task scripts - #1186
Merged
Conversation
This was referenced Mar 28, 2026
MemberAuthor
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 29, 2026 11:36
3af4839 to
3048c0dComparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 29, 2026 14:52
3048c0d to
ad0a0c7Comparegraphite-appBotforce-pushed
the
vp-run-no-fallback
branch
from
March 29, 2026 15:44
ad0a0c7 to
6c24f5aComparegraphite-appBotforce-pushed
the
fix-issue-1176
branch
from
March 29, 2026 15:44
3fcad86 to
756e54fComparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 02:39
6c24f5a to
707c56aComparefengmk2
marked this pull request as ready for review
March 30, 2026 02:43
fengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 06:33
707c56a to
9a5c382Comparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 06:49
9a5c382 to
e4862b2Comparefengmk2force-pushed
the
fix-issue-1176
branch
2 times, most recently
from
March 30, 2026 07:24
538ff45 to
ffbfc0cComparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 07:24
e4862b2 to
f898075Comparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 07:40
f898075 to
0e5b9c2Comparefengmk2
commented
Mar 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
graphite-appBotforce-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 08:21
0e5b9c2 to
c682cb1Comparegraphite-appBotforce-pushed
the
fix-issue-1176
branch
from
March 30, 2026 08:37
82e412a to
110f3c9Compare✅ Deploy Preview for viteplus-preview canceled.
|
vite as a vp command in task scriptsvite as vp and synthesize vpr in task scriptswan9chi
approved these changes
Mar 30, 2026
Merge activity
|
…ripts (#1186) ## Summary - **Fix**: `VitePlusCommandHandler` was intercepting both `vp` and `vite` program names in task scripts. This caused `vp run dev` to fail with "Invalid vite task command" when a package.json script used bare `vite` (e.g. `"dev": "vite"`), because `vite` is a separate tool, not a vp alias. Now only `vp` and `vpr` are intercepted; `vite` runs verbatim as an external process. - **Feat**: `vpr` commands in task scripts (e.g. `"ready": "vpr hello && vpr dev"`) are now expanded to `vp run` and synthesized in-session, avoiding unnecessary process spawns. ## Test plan - [x] Added snap test `command-run-script-vite-program` covering: - bare `vite`, `vite -h`, `vite --version` all run verbatim - `vpr hello` synthesized in-session - chained `vpr hello-vpr && vpr dev-version` both synthesized - [x] All 254 global snap tests pass - [x] All 22 Rust unit tests pass - [x] Verified on real reproduction project (`vp run dev` starts Vite dev server) Closes#1176
graphite-appBotforce-pushed
the
fix-issue-1176
branch
from
March 30, 2026 13:16
e60358a to
cf7593eCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VitePlusCommandHandlerwas intercepting bothvpandviteprogram names in task scripts. This causedvp run devto fail with "Invalid vite task command" when a package.json script used barevite(e.g."dev": "vite"), becauseviteis a separate tool, not a vp alias. Now onlyvpandvprare intercepted;viteruns verbatim as an external process.vprcommands in task scripts (e.g."ready": "vpr hello && vpr dev") are now expanded tovp runand synthesized in-session, avoiding unnecessary process spawns.Test plan
command-run-script-vite-programcovering:vite,vite -h,vite --versionall run verbatimvpr hellosynthesized in-sessionvpr hello-vpr && vpr dev-versionboth synthesizedvp run devstarts Vite dev server)Closes#1176